yul/bookwyrm-mastodon
1
1
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Better default edition logic

Browse Source
This commit is contained in:
Mouse Reeve 2020-04-02 08:44:34 -07:00
parent f4c088e465
commit 2b451f65ab
1 changed files with 8 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
fedireads/connectors/openlibrary.py
View File

@ -86,12 +86,16 @@ class Connector(AbstractConnector):
'oclc_numbers': ('oclc_number', lambda a: a[0]), 'oclc_numbers': ('oclc_number', lambda a: a[0]),
'lccn': ('lccn', lambda a: a[0]), 'lccn': ('lccn', lambda a: a[0]),
'languages': ('languages', get_languages), 'languages': ('languages', get_languages),
'number_of_pages': ('pages', None),
'series': ('series', lambda a: a[0]),
} }
book = update_from_mappings(book, data, mappings) book = update_from_mappings(book, data, mappings)
if 'identifiers' in data: if 'identifiers' in data:
if 'goodreads' in data['identifiers']: if 'goodreads' in data['identifiers']:
book.goodreads_key = data['identifiers']['goodreads'][0] book.goodreads_key = data['identifiers']['goodreads'][0]
if 'series' in data and len(data['series']) > 1:
book.series_number = data['series'][1]
if not book.connector: if not book.connector:
book.connector = self.connector book.connector = self.connector
@ -136,20 +140,18 @@ class Connector(AbstractConnector):
edition_data = response.json() edition_data = response.json()
options = edition_data.get('entries', []) options = edition_data.get('entries', [])
if default_only: if default_only and len(options) > 1:
options = [e for e in options if e.get('cover')] or options options = [e for e in options if e.get('cover')] or options
options = [e for e in options if \ options = [e for e in options if \
'/languages/eng' in str(e.get('languages'))] or options '/languages/eng' in str(e.get('languages'))] or options
formats = ['paperback', 'hardcover', 'mass market paperback'] formats = ['paperback', 'hardcover', 'mass market paperback']
options = [e for e in options if \ options = [e for e in options if \
str(e.get('physical_format')).lower() in formats] or options str(e.get('physical_format')).lower() in formats] or options
options = sorted( options = [e for e in options if e.get('isbn_13')] or options
options, options = [e for e in options if e.get('ocaid')] or options
key=lambda e: e.get('publish_date', '3000')
)
if not options: if not options:
return options = edition_data.get('entries', [])
options = options[:1] options = options[:1]
for data in options: for data in options:
@ -209,28 +211,6 @@ class Connector(AbstractConnector):
return [image_name, image_content] return [image_name, image_content]
def set_default_edition(work):
''' pick one edition to be what gets shown by default '''
# check for an existing default work, in which case we're done
if models.Edition.objects.filter(
parent_work=work,
default=True
).count():
return
editions = models.Edition.objects.filter(
parent_work=work,
).all()
options = [e for e in editions if 'English' in e.languages] or editions
options = [e for e in options if e.cover] or options
options = sorted(
options,
key=lambda e: e.published_date.year if e.published_date else 3000
)
if len(options):
options[0].default = True
options[0].save()
def get_description(description_blob): def get_description(description_blob):
''' descriptions can be a string or a dict ''' ''' descriptions can be a string or a dict '''
if isinstance(description_blob, dict): if isinstance(description_blob, dict):