Updates usage of resolve_remote_id

This commit is contained in:
Mouse Reeve 2021-02-16 19:35:43 -08:00
parent e2f921b7f5
commit 3f61675a0a
5 changed files with 9 additions and 7 deletions

View File

@ -7,7 +7,7 @@ class Connector(AbstractMinimalConnector):
''' this is basically just for search ''' ''' this is basically just for search '''
def get_or_create_book(self, remote_id): def get_or_create_book(self, remote_id):
edition = activitypub.resolve_remote_id(models.Edition, remote_id) edition = activitypub.resolve_remote_id(remote_id, model=models.Edition)
work = edition.parent_work work = edition.parent_work
work.default_edition = work.get_default_edition() work.default_edition = work.get_default_edition()
work.save() work.save()

View File

@ -279,7 +279,8 @@ class ManyToManyField(ActivitypubFieldMixin, models.ManyToManyField):
except ValidationError: except ValidationError:
continue continue
items.append( items.append(
activitypub.resolve_remote_id(remote_id, model=self.related_model) activitypub.resolve_remote_id(
remote_id, model=self.related_model)
) )
return items return items
@ -316,7 +317,8 @@ class TagField(ManyToManyField):
# tags can contain multiple types # tags can contain multiple types
continue continue
items.append( items.append(
activitypub.resolve_remote_id(link.href, model=self.related_model) activitypub.resolve_remote_id(
link.href, model=self.related_model)
) )
return items return items

View File

@ -84,7 +84,7 @@ class Status(OrderedCollectionPageMixin, BookWyrmModel):
related_status=self, related_status=self,
) )
def delete(self, *args, **kwargs): def delete(self, *args, **kwargs):#pylint: disable=unused-argument
''' "delete" a status ''' ''' "delete" a status '''
self.deleted = True self.deleted = True
self.deleted_date = timezone.now() self.deleted_date = timezone.now()

View File

@ -79,7 +79,7 @@ class BaseActivity(TestCase):
def test_resolve_remote_id(self): def test_resolve_remote_id(self):
''' look up or load remote data ''' ''' look up or load remote data '''
# existing item # existing item
result = resolve_remote_id(models.User, 'http://example.com/a/b') result = resolve_remote_id('http://example.com/a/b', model=models.User)
self.assertEqual(result, self.user) self.assertEqual(result, self.user)
# remote item # remote item
@ -91,7 +91,7 @@ class BaseActivity(TestCase):
with patch('bookwyrm.models.user.set_remote_server.delay'): with patch('bookwyrm.models.user.set_remote_server.delay'):
result = resolve_remote_id( result = resolve_remote_id(
models.User, 'https://example.com/user/mouse') 'https://example.com/user/mouse', model=models.User)
self.assertIsInstance(result, models.User) self.assertIsInstance(result, models.User)
self.assertEqual(result.remote_id, 'https://example.com/user/mouse') self.assertEqual(result.remote_id, 'https://example.com/user/mouse')
self.assertEqual(result.name, 'MOUSE?? MOUSE!!') self.assertEqual(result.name, 'MOUSE?? MOUSE!!')

View File

@ -162,7 +162,7 @@ def handle_remote_webfinger(query):
if link.get('rel') == 'self': if link.get('rel') == 'self':
try: try:
user = activitypub.resolve_remote_id( user = activitypub.resolve_remote_id(
models.User, link['href'] link['href'], model=models.User
) )
except KeyError: except KeyError:
return None return None