clean up List db queries

- don't unnecessarily query DB in List views
- use more efficient query in remove_from_group List class method
This commit is contained in:
Hugh Rundle
2021-10-15 17:56:23 +11:00
parent 5d7f77021b
commit 41f27a4a66
2 changed files with 3 additions and 8 deletions

View File

@ -101,15 +101,10 @@ class List(OrderedCollectionMixin, BookWyrmModel):
def remove_from_group(cls, owner, user):
"""remove a list from a group"""
memberships = GroupMember.objects.filter(group__user=owner, user=user).all()
for membership in memberships:
# remove this user's group-curated lists from the group
cls.objects.filter(group=membership.group, user=membership.user).update(
cls.objects.filter(group__user=owner, user=user).all().update(
group=None, curation="closed"
)
class ListItem(CollectionItemMixin, BookWyrmModel):
"""ok"""