From 44e87c01ab6c8daebfd7d8e929d8250c47165bc9 Mon Sep 17 00:00:00 2001 From: Mouse Reeve Date: Sat, 3 Apr 2021 11:07:08 -0700 Subject: [PATCH] Another place where redis may be called unnecessarily --- bookwyrm/activitystreams.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/bookwyrm/activitystreams.py b/bookwyrm/activitystreams.py index 419e20c0..689d396b 100644 --- a/bookwyrm/activitystreams.py +++ b/bookwyrm/activitystreams.py @@ -53,9 +53,11 @@ class ActivityStream(ABC): def add_user_statuses(self, viewer, user): """ add a user's statuses to another user's feed """ pipeline = r.pipeline() - for status in user.status_set.all()[: settings.MAX_STREAM_LENGTH]: + statuses = user.status_set.all()[: settings.MAX_STREAM_LENGTH] + for status in statuses: pipeline.zadd(self.stream_id(viewer), self.get_value(status)) - pipeline.zremrangebyrank(self.stream_id(user), settings.MAX_STREAM_LENGTH, -1) + if statuses: + pipeline.zremrangebyrank(self.stream_id(user), settings.MAX_STREAM_LENGTH, -1) pipeline.execute() def remove_user_statuses(self, viewer, user):