From 577bc18a47e3893ec382b2160de65f9dc5db5d13 Mon Sep 17 00:00:00 2001
From: Mouse Reeve <mousereeve@riseup.net>
Date: Thu, 27 Jan 2022 12:05:26 -0800
Subject: [PATCH] Minor simplification for user shelf view

---
 bookwyrm/views/user.py | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/bookwyrm/views/user.py b/bookwyrm/views/user.py
index 9deea14b..1b3b26df 100644
--- a/bookwyrm/views/user.py
+++ b/bookwyrm/views/user.py
@@ -30,17 +30,15 @@ class User(View):
 
         shelf_preview = []
 
-        # only show other shelves that should be visible
+        # only show shelves that should be visible
         shelves = user.shelf_set
         is_self = request.user.id == user.id
         if not is_self:
             shelves = models.Shelf.privacy_filter(
                 request.user, privacy_levels=["public", "followers"]
-            ).filter(user=user)
+            ).filter(user=user, books__isnull=False)
 
-        for user_shelf in shelves.all():
-            if not user_shelf.books.count():
-                continue
+        for user_shelf in shelves[:3]:
             shelf_preview.append(
                 {
                     "name": user_shelf.name,
@@ -49,8 +47,6 @@ class User(View):
                     "size": user_shelf.books.count(),
                 }
             )
-            if len(shelf_preview) > 2:
-                break
 
         # user's posts
         activities = (