From 5939a72c811aa0ab259903ba5844d3cbb7849fe6 Mon Sep 17 00:00:00 2001 From: Mouse Reeve Date: Sun, 31 Jan 2021 13:31:49 -0800 Subject: [PATCH] More list models tests --- bookwyrm/models/list.py | 2 +- bookwyrm/tests/models/test_list.py | 22 ++++++++++++++++++++++ 2 files changed, 23 insertions(+), 1 deletion(-) diff --git a/bookwyrm/models/list.py b/bookwyrm/models/list.py index 28ee7a2a..96bf0b7a 100644 --- a/bookwyrm/models/list.py +++ b/bookwyrm/models/list.py @@ -80,7 +80,7 @@ class ListItem(ActivitypubMixin, BookWyrmModel): id='%s#remove' % self.remote_id, actor=user.remote_id, object=self.book.to_activity(), - target=self.book_list.to_activity() + target=self.book_list.remote_id ).serialize() class Meta: diff --git a/bookwyrm/tests/models/test_list.py b/bookwyrm/tests/models/test_list.py index ba90d961..ce7b1867 100644 --- a/bookwyrm/tests/models/test_list.py +++ b/bookwyrm/tests/models/test_list.py @@ -30,3 +30,25 @@ class List(TestCase): self.assertEqual(activity_json['type'], 'OrderedCollection') self.assertEqual(activity_json['name'], 'Test List') self.assertEqual(activity_json['owner'], self.user.remote_id) + + def test_list_item(self): + ''' a list entry ''' + work = models.Work.objects.create(title='hello') + book = models.Edition.objects.create(title='hi', parent_work=work) + item = models.ListItem.objects.create( + book_list=self.list, + book=book, + added_by=self.user, + ) + + self.assertTrue(item.approved) + + add_activity = item.to_add_activity(self.user) + self.assertEqual(add_activity['actor'], self.user.remote_id) + self.assertEqual(add_activity['object']['id'], book.remote_id) + self.assertEqual(add_activity['target'], self.list.remote_id) + + remove_activity = item.to_remove_activity(self.user) + self.assertEqual(remove_activity['actor'], self.user.remote_id) + self.assertEqual(remove_activity['object']['id'], book.remote_id) + self.assertEqual(remove_activity['target'], self.list.remote_id)