Separate out test files and add more tests
This commit is contained in:
Mouse Reeve
parent
3d92afdf28
commit
5c2d6e6510
|
|
@ -1,14 +1,12 @@
|
||||||
""" test for app action functionality """
|
""" test for app action functionality """
|
||||||
import json
|
|
||||||
from unittest.mock import patch
|
from unittest.mock import patch
|
||||||
|
|
||||||
from django.contrib.auth.models import AnonymousUser
|
from django.contrib.auth.models import AnonymousUser
|
||||||
from django.core.exceptions import PermissionDenied
|
|
||||||
from django.template.response import TemplateResponse
|
from django.template.response import TemplateResponse
|
||||||
from django.test import TestCase
|
from django.test import TestCase
|
||||||
from django.test.client import RequestFactory
|
from django.test.client import RequestFactory
|
||||||
|
|
||||||
from bookwyrm import forms, models, views
|
from bookwyrm import models, views
|
||||||
from bookwyrm.activitypub import ActivitypubResponse
|
from bookwyrm.activitypub import ActivitypubResponse
|
||||||
from bookwyrm.tests.validate_html import validate_html
|
from bookwyrm.tests.validate_html import validate_html
|
||||||
|
|
||||||
|
|
@ -165,152 +163,3 @@ class ShelfViews(TestCase):
|
||||||
view(request, request.user.username, shelf.identifier)
|
view(request, request.user.username, shelf.identifier)
|
||||||
|
|
||||||
self.assertEqual(shelf.name, "To Read")
|
self.assertEqual(shelf.name, "To Read")
|
||||||
|
|
||||||
def test_shelve(self, *_):
|
|
||||||
"""shelve a book"""
|
|
||||||
request = self.factory.post(
|
|
||||||
"", {"book": self.book.id, "shelf": self.shelf.identifier}
|
|
||||||
)
|
|
||||||
request.user = self.local_user
|
|
||||||
with patch("bookwyrm.models.activitypub_mixin.broadcast_task.delay") as mock:
|
|
||||||
views.shelve(request)
|
|
||||||
|
|
||||||
self.assertEqual(mock.call_count, 1)
|
|
||||||
activity = json.loads(mock.call_args[0][1])
|
|
||||||
self.assertEqual(activity["type"], "Add")
|
|
||||||
|
|
||||||
item = models.ShelfBook.objects.get()
|
|
||||||
self.assertEqual(activity["object"]["id"], item.remote_id)
|
|
||||||
# make sure the book is on the shelf
|
|
||||||
self.assertEqual(self.shelf.books.get(), self.book)
|
|
||||||
|
|
||||||
def test_shelve_to_read(self, *_):
|
|
||||||
"""special behavior for the to-read shelf"""
|
|
||||||
shelf = models.Shelf.objects.get(identifier="to-read")
|
|
||||||
request = self.factory.post(
|
|
||||||
"", {"book": self.book.id, "shelf": shelf.identifier}
|
|
||||||
)
|
|
||||||
request.user = self.local_user
|
|
||||||
|
|
||||||
with patch("bookwyrm.models.activitypub_mixin.broadcast_task.delay"):
|
|
||||||
views.shelve(request)
|
|
||||||
# make sure the book is on the shelf
|
|
||||||
self.assertEqual(shelf.books.get(), self.book)
|
|
||||||
|
|
||||||
def test_shelve_reading(self, *_):
|
|
||||||
"""special behavior for the reading shelf"""
|
|
||||||
shelf = models.Shelf.objects.get(identifier="reading")
|
|
||||||
request = self.factory.post(
|
|
||||||
"", {"book": self.book.id, "shelf": shelf.identifier}
|
|
||||||
)
|
|
||||||
request.user = self.local_user
|
|
||||||
|
|
||||||
with patch("bookwyrm.models.activitypub_mixin.broadcast_task.delay"):
|
|
||||||
views.shelve(request)
|
|
||||||
# make sure the book is on the shelf
|
|
||||||
self.assertEqual(shelf.books.get(), self.book)
|
|
||||||
|
|
||||||
def test_shelve_read(self, *_):
|
|
||||||
"""special behavior for the read shelf"""
|
|
||||||
shelf = models.Shelf.objects.get(identifier="read")
|
|
||||||
request = self.factory.post(
|
|
||||||
"", {"book": self.book.id, "shelf": shelf.identifier}
|
|
||||||
)
|
|
||||||
request.user = self.local_user
|
|
||||||
|
|
||||||
with patch("bookwyrm.models.activitypub_mixin.broadcast_task.delay"):
|
|
||||||
views.shelve(request)
|
|
||||||
# make sure the book is on the shelf
|
|
||||||
self.assertEqual(shelf.books.get(), self.book)
|
|
||||||
|
|
||||||
def test_unshelve(self, *_):
|
|
||||||
"""remove a book from a shelf"""
|
|
||||||
with patch("bookwyrm.models.activitypub_mixin.broadcast_task.delay"):
|
|
||||||
models.ShelfBook.objects.create(
|
|
||||||
book=self.book, user=self.local_user, shelf=self.shelf
|
|
||||||
)
|
|
||||||
item = models.ShelfBook.objects.get()
|
|
||||||
|
|
||||||
self.shelf.save()
|
|
||||||
self.assertEqual(self.shelf.books.count(), 1)
|
|
||||||
request = self.factory.post("", {"book": self.book.id, "shelf": self.shelf.id})
|
|
||||||
request.user = self.local_user
|
|
||||||
with patch("bookwyrm.models.activitypub_mixin.broadcast_task.delay") as mock:
|
|
||||||
views.unshelve(request)
|
|
||||||
activity = json.loads(mock.call_args[0][1])
|
|
||||||
self.assertEqual(activity["type"], "Remove")
|
|
||||||
self.assertEqual(activity["object"]["id"], item.remote_id)
|
|
||||||
self.assertEqual(self.shelf.books.count(), 0)
|
|
||||||
|
|
||||||
def test_create_shelf(self, *_):
|
|
||||||
"""a brand new custom shelf"""
|
|
||||||
form = forms.ShelfForm()
|
|
||||||
form.data["user"] = self.local_user.id
|
|
||||||
form.data["name"] = "new shelf name"
|
|
||||||
form.data["description"] = "desc"
|
|
||||||
form.data["privacy"] = "unlisted"
|
|
||||||
request = self.factory.post("", form.data)
|
|
||||||
request.user = self.local_user
|
|
||||||
|
|
||||||
views.create_shelf(request)
|
|
||||||
|
|
||||||
shelf = models.Shelf.objects.get(name="new shelf name")
|
|
||||||
self.assertEqual(shelf.privacy, "unlisted")
|
|
||||||
self.assertEqual(shelf.description, "desc")
|
|
||||||
self.assertEqual(shelf.user, self.local_user)
|
|
||||||
|
|
||||||
def test_delete_shelf(self, *_):
|
|
||||||
"""delete a brand new custom shelf"""
|
|
||||||
request = self.factory.post("")
|
|
||||||
request.user = self.local_user
|
|
||||||
shelf_id = self.shelf.id
|
|
||||||
|
|
||||||
views.delete_shelf(request, shelf_id)
|
|
||||||
|
|
||||||
self.assertFalse(models.Shelf.objects.filter(id=shelf_id).exists())
|
|
||||||
|
|
||||||
def test_delete_shelf_unauthorized(self, *_):
|
|
||||||
"""delete a brand new custom shelf"""
|
|
||||||
with patch("bookwyrm.suggested_users.rerank_suggestions_task.delay"), patch(
|
|
||||||
"bookwyrm.activitystreams.populate_stream_task.delay"
|
|
||||||
):
|
|
||||||
rat = models.User.objects.create_user(
|
|
||||||
"rat@local.com",
|
|
||||||
"rat@mouse.mouse",
|
|
||||||
"password",
|
|
||||||
local=True,
|
|
||||||
localname="rat",
|
|
||||||
)
|
|
||||||
request = self.factory.post("")
|
|
||||||
request.user = rat
|
|
||||||
|
|
||||||
with self.assertRaises(PermissionDenied):
|
|
||||||
views.delete_shelf(request, self.shelf.id)
|
|
||||||
|
|
||||||
self.assertTrue(models.Shelf.objects.filter(id=self.shelf.id).exists())
|
|
||||||
|
|
||||||
def test_delete_shelf_has_book(self, *_):
|
|
||||||
"""delete a brand new custom shelf"""
|
|
||||||
with patch("bookwyrm.models.activitypub_mixin.broadcast_task.delay"):
|
|
||||||
models.ShelfBook.objects.create(
|
|
||||||
book=self.book, user=self.local_user, shelf=self.shelf
|
|
||||||
)
|
|
||||||
request = self.factory.post("")
|
|
||||||
request.user = self.local_user
|
|
||||||
|
|
||||||
with self.assertRaises(PermissionDenied):
|
|
||||||
views.delete_shelf(request, self.shelf.id)
|
|
||||||
|
|
||||||
self.assertTrue(models.Shelf.objects.filter(id=self.shelf.id).exists())
|
|
||||||
|
|
||||||
def test_delete_shelf_not_editable(self, *_):
|
|
||||||
"""delete a brand new custom shelf"""
|
|
||||||
shelf = self.local_user.shelf_set.first()
|
|
||||||
self.assertFalse(shelf.editable)
|
|
||||||
request = self.factory.post("")
|
|
||||||
request.user = self.local_user
|
|
||||||
|
|
||||||
with self.assertRaises(PermissionDenied):
|
|
||||||
views.delete_shelf(request, shelf.id)
|
|
||||||
|
|
||||||
self.assertTrue(models.Shelf.objects.filter(id=shelf.id).exists())
|
|
||||||
|
|
|
||||||
|
|
@ -0,0 +1,216 @@
|
||||||
|
""" test for app action functionality """
|
||||||
|
import json
|
||||||
|
from unittest.mock import patch
|
||||||
|
|
||||||
|
from django.core.exceptions import PermissionDenied
|
||||||
|
from django.test import TestCase
|
||||||
|
from django.test.client import RequestFactory
|
||||||
|
|
||||||
|
from bookwyrm import forms, models, views
|
||||||
|
|
||||||
|
|
||||||
|
@patch("bookwyrm.models.activitypub_mixin.broadcast_task.delay")
|
||||||
|
@patch("bookwyrm.suggested_users.rerank_suggestions_task.delay")
|
||||||
|
@patch("bookwyrm.activitystreams.populate_stream_task.delay")
|
||||||
|
@patch("bookwyrm.activitystreams.add_book_statuses_task.delay")
|
||||||
|
@patch("bookwyrm.activitystreams.remove_book_statuses_task.delay")
|
||||||
|
class ShelfActionViews(TestCase):
|
||||||
|
"""tag views"""
|
||||||
|
|
||||||
|
def setUp(self):
|
||||||
|
"""we need basic test data and mocks"""
|
||||||
|
self.factory = RequestFactory()
|
||||||
|
with patch("bookwyrm.suggested_users.rerank_suggestions_task.delay"), patch(
|
||||||
|
"bookwyrm.activitystreams.populate_stream_task.delay"
|
||||||
|
):
|
||||||
|
self.local_user = models.User.objects.create_user(
|
||||||
|
"mouse@local.com",
|
||||||
|
"mouse@mouse.com",
|
||||||
|
"mouseword",
|
||||||
|
local=True,
|
||||||
|
localname="mouse",
|
||||||
|
remote_id="https://example.com/users/mouse",
|
||||||
|
)
|
||||||
|
self.work = models.Work.objects.create(title="Test Work")
|
||||||
|
self.book = models.Edition.objects.create(
|
||||||
|
title="Example Edition",
|
||||||
|
remote_id="https://example.com/book/1",
|
||||||
|
parent_work=self.work,
|
||||||
|
)
|
||||||
|
with patch("bookwyrm.models.activitypub_mixin.broadcast_task.delay"):
|
||||||
|
self.shelf = models.Shelf.objects.create(
|
||||||
|
name="Test Shelf", identifier="test-shelf", user=self.local_user
|
||||||
|
)
|
||||||
|
models.SiteSettings.objects.create()
|
||||||
|
|
||||||
|
def test_shelve(self, *_):
|
||||||
|
"""shelve a book"""
|
||||||
|
request = self.factory.post(
|
||||||
|
"", {"book": self.book.id, "shelf": self.shelf.identifier}
|
||||||
|
)
|
||||||
|
request.user = self.local_user
|
||||||
|
with patch("bookwyrm.models.activitypub_mixin.broadcast_task.delay") as mock:
|
||||||
|
views.shelve(request)
|
||||||
|
|
||||||
|
self.assertEqual(mock.call_count, 1)
|
||||||
|
activity = json.loads(mock.call_args[0][1])
|
||||||
|
self.assertEqual(activity["type"], "Add")
|
||||||
|
|
||||||
|
item = models.ShelfBook.objects.get()
|
||||||
|
self.assertEqual(activity["object"]["id"], item.remote_id)
|
||||||
|
# make sure the book is on the shelf
|
||||||
|
self.assertEqual(self.shelf.books.get(), self.book)
|
||||||
|
|
||||||
|
def test_shelve_to_read(self, *_):
|
||||||
|
"""special behavior for the to-read shelf"""
|
||||||
|
shelf = models.Shelf.objects.get(identifier="to-read")
|
||||||
|
request = self.factory.post(
|
||||||
|
"", {"book": self.book.id, "shelf": shelf.identifier}
|
||||||
|
)
|
||||||
|
request.user = self.local_user
|
||||||
|
|
||||||
|
with patch("bookwyrm.models.activitypub_mixin.broadcast_task.delay"):
|
||||||
|
views.shelve(request)
|
||||||
|
# make sure the book is on the shelf
|
||||||
|
self.assertEqual(shelf.books.get(), self.book)
|
||||||
|
|
||||||
|
def test_shelve_reading(self, *_):
|
||||||
|
"""special behavior for the reading shelf"""
|
||||||
|
shelf = models.Shelf.objects.get(identifier="reading")
|
||||||
|
request = self.factory.post(
|
||||||
|
"", {"book": self.book.id, "shelf": shelf.identifier}
|
||||||
|
)
|
||||||
|
request.user = self.local_user
|
||||||
|
|
||||||
|
with patch("bookwyrm.models.activitypub_mixin.broadcast_task.delay"):
|
||||||
|
views.shelve(request)
|
||||||
|
# make sure the book is on the shelf
|
||||||
|
self.assertEqual(shelf.books.get(), self.book)
|
||||||
|
|
||||||
|
def test_shelve_read(self, *_):
|
||||||
|
"""special behavior for the read shelf"""
|
||||||
|
shelf = models.Shelf.objects.get(identifier="read")
|
||||||
|
request = self.factory.post(
|
||||||
|
"", {"book": self.book.id, "shelf": shelf.identifier}
|
||||||
|
)
|
||||||
|
request.user = self.local_user
|
||||||
|
|
||||||
|
with patch("bookwyrm.models.activitypub_mixin.broadcast_task.delay"):
|
||||||
|
views.shelve(request)
|
||||||
|
# make sure the book is on the shelf
|
||||||
|
self.assertEqual(shelf.books.get(), self.book)
|
||||||
|
|
||||||
|
def test_shelve_read_with_change_shelf(self, *_):
|
||||||
|
"""special behavior for the read shelf"""
|
||||||
|
previous_shelf = models.Shelf.objects.get(identifier="reading")
|
||||||
|
models.ShelfBook.objects.create(
|
||||||
|
shelf=previous_shelf, user=self.local_user, book=self.book
|
||||||
|
)
|
||||||
|
shelf = models.Shelf.objects.get(identifier="read")
|
||||||
|
|
||||||
|
request = self.factory.post(
|
||||||
|
"", {
|
||||||
|
"book": self.book.id,
|
||||||
|
"shelf": shelf.identifier,
|
||||||
|
"change-shelf-from": previous_shelf.identifier,
|
||||||
|
}
|
||||||
|
)
|
||||||
|
request.user = self.local_user
|
||||||
|
|
||||||
|
with patch("bookwyrm.models.activitypub_mixin.broadcast_task.delay"):
|
||||||
|
views.shelve(request)
|
||||||
|
# make sure the book is on the shelf
|
||||||
|
self.assertEqual(shelf.books.get(), self.book)
|
||||||
|
self.assertEqual(list(previous_shelf.books.all()), [])
|
||||||
|
|
||||||
|
def test_unshelve(self, *_):
|
||||||
|
"""remove a book from a shelf"""
|
||||||
|
with patch("bookwyrm.models.activitypub_mixin.broadcast_task.delay"):
|
||||||
|
models.ShelfBook.objects.create(
|
||||||
|
book=self.book, user=self.local_user, shelf=self.shelf
|
||||||
|
)
|
||||||
|
item = models.ShelfBook.objects.get()
|
||||||
|
|
||||||
|
self.shelf.save()
|
||||||
|
self.assertEqual(self.shelf.books.count(), 1)
|
||||||
|
request = self.factory.post("", {"book": self.book.id, "shelf": self.shelf.id})
|
||||||
|
request.user = self.local_user
|
||||||
|
with patch("bookwyrm.models.activitypub_mixin.broadcast_task.delay") as mock:
|
||||||
|
views.unshelve(request)
|
||||||
|
activity = json.loads(mock.call_args[0][1])
|
||||||
|
self.assertEqual(activity["type"], "Remove")
|
||||||
|
self.assertEqual(activity["object"]["id"], item.remote_id)
|
||||||
|
self.assertEqual(self.shelf.books.count(), 0)
|
||||||
|
|
||||||
|
def test_create_shelf(self, *_):
|
||||||
|
"""a brand new custom shelf"""
|
||||||
|
form = forms.ShelfForm()
|
||||||
|
form.data["user"] = self.local_user.id
|
||||||
|
form.data["name"] = "new shelf name"
|
||||||
|
form.data["description"] = "desc"
|
||||||
|
form.data["privacy"] = "unlisted"
|
||||||
|
request = self.factory.post("", form.data)
|
||||||
|
request.user = self.local_user
|
||||||
|
|
||||||
|
views.create_shelf(request)
|
||||||
|
|
||||||
|
shelf = models.Shelf.objects.get(name="new shelf name")
|
||||||
|
self.assertEqual(shelf.privacy, "unlisted")
|
||||||
|
self.assertEqual(shelf.description, "desc")
|
||||||
|
self.assertEqual(shelf.user, self.local_user)
|
||||||
|
|
||||||
|
def test_delete_shelf(self, *_):
|
||||||
|
"""delete a brand new custom shelf"""
|
||||||
|
request = self.factory.post("")
|
||||||
|
request.user = self.local_user
|
||||||
|
shelf_id = self.shelf.id
|
||||||
|
|
||||||
|
views.delete_shelf(request, shelf_id)
|
||||||
|
|
||||||
|
self.assertFalse(models.Shelf.objects.filter(id=shelf_id).exists())
|
||||||
|
|
||||||
|
def test_delete_shelf_unauthorized(self, *_):
|
||||||
|
"""delete a brand new custom shelf"""
|
||||||
|
with patch("bookwyrm.suggested_users.rerank_suggestions_task.delay"), patch(
|
||||||
|
"bookwyrm.activitystreams.populate_stream_task.delay"
|
||||||
|
):
|
||||||
|
rat = models.User.objects.create_user(
|
||||||
|
"rat@local.com",
|
||||||
|
"rat@mouse.mouse",
|
||||||
|
"password",
|
||||||
|
local=True,
|
||||||
|
localname="rat",
|
||||||
|
)
|
||||||
|
request = self.factory.post("")
|
||||||
|
request.user = rat
|
||||||
|
|
||||||
|
with self.assertRaises(PermissionDenied):
|
||||||
|
views.delete_shelf(request, self.shelf.id)
|
||||||
|
|
||||||
|
self.assertTrue(models.Shelf.objects.filter(id=self.shelf.id).exists())
|
||||||
|
|
||||||
|
def test_delete_shelf_has_book(self, *_):
|
||||||
|
"""delete a brand new custom shelf"""
|
||||||
|
with patch("bookwyrm.models.activitypub_mixin.broadcast_task.delay"):
|
||||||
|
models.ShelfBook.objects.create(
|
||||||
|
book=self.book, user=self.local_user, shelf=self.shelf
|
||||||
|
)
|
||||||
|
request = self.factory.post("")
|
||||||
|
request.user = self.local_user
|
||||||
|
|
||||||
|
with self.assertRaises(PermissionDenied):
|
||||||
|
views.delete_shelf(request, self.shelf.id)
|
||||||
|
|
||||||
|
self.assertTrue(models.Shelf.objects.filter(id=self.shelf.id).exists())
|
||||||
|
|
||||||
|
def test_delete_shelf_not_editable(self, *_):
|
||||||
|
"""delete a brand new custom shelf"""
|
||||||
|
shelf = self.local_user.shelf_set.first()
|
||||||
|
self.assertFalse(shelf.editable)
|
||||||
|
request = self.factory.post("")
|
||||||
|
request.user = self.local_user
|
||||||
|
|
||||||
|
with self.assertRaises(PermissionDenied):
|
||||||
|
views.delete_shelf(request, shelf.id)
|
||||||
|
|
||||||
|
self.assertTrue(models.Shelf.objects.filter(id=shelf.id).exists())
|
||||||
Loading…
Reference in New Issue