From 628f104b13e52a571eb2b88d095f42b9c778fb54 Mon Sep 17 00:00:00 2001
From: Mouse Reeve <mousereeve@riseup.net>
Date: Sat, 13 Nov 2021 10:16:25 -0800
Subject: [PATCH] Separates out imports views tests

---
 bookwyrm/tests/views/imports/test_import.py   | 32 ----------
 .../views/imports/test_import_troubleshoot.py | 59 +++++++++++++++++++
 2 files changed, 59 insertions(+), 32 deletions(-)
 create mode 100644 bookwyrm/tests/views/imports/test_import_troubleshoot.py

diff --git a/bookwyrm/tests/views/imports/test_import.py b/bookwyrm/tests/views/imports/test_import.py
index 4a6a8237..7de5e8c8 100644
--- a/bookwyrm/tests/views/imports/test_import.py
+++ b/bookwyrm/tests/views/imports/test_import.py
@@ -51,19 +51,6 @@ class ImportViews(TestCase):
         validate_html(result.render())
         self.assertEqual(result.status_code, 200)
 
-    def test_import_troubleshoot_get(self):
-        """there are so many views, this just makes sure it LOADS"""
-        view = views.ImportTroubleshoot.as_view()
-        import_job = models.ImportJob.objects.create(user=self.local_user, mappings={})
-        request = self.factory.get("")
-        request.user = self.local_user
-        with patch("bookwyrm.tasks.app.AsyncResult") as async_result:
-            async_result.return_value = []
-            result = view(request, import_job.id)
-        self.assertIsInstance(result, TemplateResponse)
-        validate_html(result.render())
-        self.assertEqual(result.status_code, 200)
-
     def test_start_import(self):
         """retry failed items"""
         view = views.Import.as_view()
@@ -87,22 +74,3 @@ class ImportViews(TestCase):
         job = models.ImportJob.objects.get()
         self.assertFalse(job.include_reviews)
         self.assertEqual(job.privacy, "public")
-
-    def test_retry_import(self):
-        """retry failed items"""
-        view = views.ImportTroubleshoot.as_view()
-        import_job = models.ImportJob.objects.create(
-            user=self.local_user, privacy="unlisted", mappings={}
-        )
-        request = self.factory.post("")
-        request.user = self.local_user
-
-        with patch("bookwyrm.importers.Importer.start_import"):
-            view(request, import_job.id)
-
-        self.assertEqual(models.ImportJob.objects.count(), 2)
-        retry_job = models.ImportJob.objects.last()
-
-        self.assertTrue(retry_job.retry)
-        self.assertEqual(retry_job.user, self.local_user)
-        self.assertEqual(retry_job.privacy, "unlisted")
diff --git a/bookwyrm/tests/views/imports/test_import_troubleshoot.py b/bookwyrm/tests/views/imports/test_import_troubleshoot.py
new file mode 100644
index 00000000..5359cc1e
--- /dev/null
+++ b/bookwyrm/tests/views/imports/test_import_troubleshoot.py
@@ -0,0 +1,59 @@
+""" test for app action functionality """
+from unittest.mock import patch
+from django.template.response import TemplateResponse
+from django.test import TestCase
+from django.test.client import RequestFactory
+from bookwyrm.tests.validate_html import validate_html
+
+from bookwyrm import models, views
+
+
+class ImportTroubleshootViews(TestCase):
+    """goodreads import views"""
+
+    def setUp(self):
+        """we need basic test data and mocks"""
+        self.factory = RequestFactory()
+        with patch("bookwyrm.suggested_users.rerank_suggestions_task.delay"), patch(
+            "bookwyrm.activitystreams.populate_stream_task.delay"
+        ):
+            self.local_user = models.User.objects.create_user(
+                "mouse@local.com",
+                "mouse@mouse.mouse",
+                "password",
+                local=True,
+                localname="mouse",
+            )
+        models.SiteSettings.objects.create()
+
+    def test_import_troubleshoot_get(self):
+        """there are so many views, this just makes sure it LOADS"""
+        view = views.ImportTroubleshoot.as_view()
+        import_job = models.ImportJob.objects.create(user=self.local_user, mappings={})
+        request = self.factory.get("")
+        request.user = self.local_user
+        with patch("bookwyrm.tasks.app.AsyncResult") as async_result:
+            async_result.return_value = []
+            result = view(request, import_job.id)
+        self.assertIsInstance(result, TemplateResponse)
+        validate_html(result.render())
+        self.assertEqual(result.status_code, 200)
+
+    def test_retry_import(self):
+        """retry failed items"""
+        view = views.ImportTroubleshoot.as_view()
+        import_job = models.ImportJob.objects.create(
+            user=self.local_user, privacy="unlisted", mappings={}
+        )
+        request = self.factory.post("")
+        request.user = self.local_user
+
+        with patch("bookwyrm.importers.Importer.start_import"):
+            view(request, import_job.id)
+
+        self.assertEqual(models.ImportJob.objects.count(), 2)
+        retry_job = models.ImportJob.objects.last()
+
+        self.assertTrue(retry_job.retry)
+        self.assertEqual(retry_job.user, self.local_user)
+        self.assertEqual(retry_job.privacy, "unlisted")