Fixes shelf model tests

2021-02-06 21:00:08 -08:00
parent b02a2c1aa4
commit 63fe9777e2
2 changed files with 79 additions and 10 deletions
--- a/bookwyrm/models/shelf.py
+++ b/bookwyrm/models/shelf.py
@ -27,12 +27,11 @@ class Shelf(OrderedCollectionMixin, BookWyrmModel):

    def save(self, *args, **kwargs):
        ''' set the identifier '''
-        saved = super().save(*args, **kwargs)
+        super().save(*args, **kwargs)
        if not self.identifier:
            slug = re.sub(r'[^\w]', '', self.name).lower()
            self.identifier = '%s-%d' % (slug, self.id)
-            return super().save(*args, **kwargs)
-        return saved
+            super().save(*args, **kwargs)

    @property
    def collection_queryset(self):