diff --git a/bookwyrm/templates/snippets/goal_form.html b/bookwyrm/templates/snippets/goal_form.html index 3afcf2ac..f4db3e96 100644 --- a/bookwyrm/templates/snippets/goal_form.html +++ b/bookwyrm/templates/snippets/goal_form.html @@ -16,21 +16,21 @@
- + + {% include 'snippets/privacy_select.html' with no_label=True current=goal.privacy uuid=goal.id %}
+ -

+

{% if goal %} {% trans "Cancel" as button_text %} {% include 'snippets/toggle/close_button.html' with text=button_text controls_text="show_edit_goal" %} {% endif %} -

+
diff --git a/bookwyrm/tests/views/test_goal.py b/bookwyrm/tests/views/test_goal.py index cb8c5d8e..741fca9c 100644 --- a/bookwyrm/tests/views/test_goal.py +++ b/bookwyrm/tests/views/test_goal.py @@ -1,12 +1,13 @@ """ test for app action functionality """ from unittest.mock import patch -from django.utils import timezone +from tidylib import tidy_document from django.contrib.auth.models import AnonymousUser from django.http import Http404 from django.template.response import TemplateResponse from django.test import TestCase from django.test.client import RequestFactory +from django.utils import timezone from bookwyrm import models, views @@ -61,7 +62,16 @@ class GoalViews(TestCase): request.user = self.local_user result = view(request, self.local_user.localname, self.year) - result.render() + html = result.render() + _, errors = tidy_document( + html.content, + options={ + "drop-empty-elements": False, + "warn-proprietary-attributes": False, + }, + ) + if errors: + raise Exception(errors) self.assertIsInstance(result, TemplateResponse) def test_goal_page_anonymous(self): @@ -92,7 +102,16 @@ class GoalViews(TestCase): request.user = self.rat result = view(request, self.local_user.localname, timezone.now().year) - result.render() + html = result.render() + _, errors = tidy_document( + html.content, + options={ + "drop-empty-elements": False, + "warn-proprietary-attributes": False, + }, + ) + if errors: + raise Exception(errors) self.assertIsInstance(result, TemplateResponse) def test_goal_page_private(self):