Merge pull request #727 from mouse-reeve/connector-tests

Connector tests
This commit is contained in:
Mouse Reeve
2021-03-13 10:24:40 -08:00
committed by GitHub
6 changed files with 60 additions and 11 deletions

View File

@ -18,7 +18,7 @@ def search(query, min_confidence=0.1):
results = []
# Have we got a ISBN ?
isbn = re.sub("[\W_]", "", query)
isbn = re.sub(r"[\W_]", "", query)
maybe_isbn = len(isbn) in [10, 13] # ISBN10 or ISBN13
dedup_slug = lambda r: "%s/%s/%s" % (r.title, r.author, r.year)
@ -36,7 +36,7 @@ def search(query, min_confidence=0.1):
pass
# if no isbn search or results, we fallback to generic search
if result_set == None or result_set == []:
if result_set in (None, []):
try:
result_set = connector.search(query, min_confidence=min_confidence)
except (HTTPError, ConnectorException):

View File

@ -161,21 +161,17 @@ def ignore_edition(edition_data):
""" don't load a million editions that have no metadata """
# an isbn, we love to see it
if edition_data.get("isbn_13") or edition_data.get("isbn_10"):
print(edition_data.get("isbn_10"))
return False
# grudgingly, oclc can stay
if edition_data.get("oclc_numbers"):
print(edition_data.get("oclc_numbers"))
return False
# if it has a cover it can stay
if edition_data.get("covers"):
print(edition_data.get("covers"))
return False
# keep non-english editions
if edition_data.get("languages") and "languages/eng" not in str(
edition_data.get("languages")
):
print(edition_data.get("languages"))
return False
return True