yul
/
bookwyrm-mastodon
1
1
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #1037 from bookwyrm-social/search-bug 

Fixes error on empty search results
This commit is contained in:
Mouse Reeve 2021-05-03 10:57:53 -07:00 committed by GitHub
parent 93959fc600 df1c324d2d
commit 7db8e249cc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
bookwyrm/tests/views/test_search.py
View File

@ -127,7 +127,7 @@ class Views(TestCase):
response = view(request) response = view(request)
response.render() response.render()
self.assertEqual(response.context_data["results"].object_list.count(), 0) self.assertFalse("results" in response.context_data)
def test_search_lists(self): def test_search_lists(self):
"""searches remote connectors""" """searches remote connectors"""

9
bookwyrm/views/search.py
View File

@ -56,10 +56,11 @@ class Search(View):
results = endpoints[search_type]( results = endpoints[search_type](
query, request.user, min_confidence, search_remote query, request.user, min_confidence, search_remote
) )
paginated = Paginator(results, PAGE_LENGTH).get_page( if results:
request.GET.get("page") paginated = Paginator(results, PAGE_LENGTH).get_page(
) request.GET.get("page")
data["results"] = paginated )
data["results"] = paginated
return TemplateResponse(request, "search/{:s}.html".format(search_type), data) return TemplateResponse(request, "search/{:s}.html".format(search_type), data)