From 89dea4461407758e8d0a96a9b8d88a5ab22d955f Mon Sep 17 00:00:00 2001
From: Hugh Rundle <hugh@hughrundle.net>
Date: Sat, 2 Oct 2021 12:29:01 +1000
Subject: [PATCH] accepting membership fixes

- don't delete the invitation twice
- send membership information properly to notification
---
 bookwyrm/models/group.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/bookwyrm/models/group.py b/bookwyrm/models/group.py
index 103764d2..fdba04ea 100644
--- a/bookwyrm/models/group.py
+++ b/bookwyrm/models/group.py
@@ -132,11 +132,11 @@ class GroupMemberInvitation(models.Model):
 
         with transaction.atomic():
             BookwyrmGroupMember.from_request(self)
-            self.delete()
 
             # let the other members know about it
             model = apps.get_model("bookwyrm.Notification", require_ready=True)
-            for member in self.group.members.all:
+            for membership in self.group.memberships.all():
+                member = membership.user 
                 if member != self.user:
                     model.objects.create(
                         user=member,