From 97ea61dd7ef095c074f6fb079c72cb58803a9545 Mon Sep 17 00:00:00 2001 From: Hugh Rundle Date: Sat, 16 Oct 2021 08:17:42 +1100 Subject: [PATCH] efficiency improvement to remove_from_group --- bookwyrm/models/list.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/bookwyrm/models/list.py b/bookwyrm/models/list.py index 9b05c81b..7ce7f922 100644 --- a/bookwyrm/models/list.py +++ b/bookwyrm/models/list.py @@ -101,11 +101,7 @@ class List(OrderedCollectionMixin, BookWyrmModel): def remove_from_group(cls, owner, user): """remove a list from a group""" - memberships = GroupMember.objects.filter(group__user=owner, user=user).all() - - for membership in memberships: - # remove this user's group-curated lists from the group - cls.objects.filter(group=membership.group, user=membership.user).update( + cls.objects.filter(group__user=owner, user=user).all().update( group=None, curation="closed" )