Various pylint complaince fixes

bookwyrm/tests/views/inbox/test_inbox_announce.py

@@ -61,7 +61,7 @@ class InboxActivities(TestCase):
         self.assertEqual(models.Notification.objects.count(), 0)
         activity = {
             "type": "Announce",
-            "id": "%s/boost" % self.status.remote_id,
+            "id": f"{self.status.remote_id}/boost",
             "actor": self.remote_user.remote_id,
             "object": self.status.remote_id,
             "to": ["https://www.w3.org/ns/activitystreams#public"],
@@ -94,7 +94,7 @@ class InboxActivities(TestCase):
         self.assertEqual(models.Notification.objects.count(), 0)
         activity = {
             "type": "Announce",
-            "id": "%s/boost" % self.status.remote_id,
+            "id": f"{self.status.remote_id}/boost",
             "actor": self.remote_user.remote_id,
             "object": "https://remote.com/status/1",
             "to": ["https://www.w3.org/ns/activitystreams#public"],

bookwyrm/tests/views/test_author.py

@@ -66,7 +66,7 @@ class AuthorViews(TestCase):
     def test_author_page_edition_author(self):
         """there are so many views, this just makes sure it LOADS"""
         view = views.Author.as_view()
-        another_book = models.Edition.objects.create(
+        models.Edition.objects.create(
             title="Example Edition",
             remote_id="https://example.com/book/1",
             parent_work=self.work,

bookwyrm/tests/views/test_helpers.py

@@ -139,7 +139,7 @@ class ViewsHelpers(TestCase):
         }
         responses.add(
             responses.GET,
-            "https://example.com/.well-known/webfinger?resource=acct:%s" % username,
+            f"https://example.com/.well-known/webfinger?resource=acct:{username}",
             json=wellknown,
             status=200,
         )

bookwyrm/tests/views/test_user.py

@@ -83,7 +83,7 @@ class UserViews(TestCase):
     def test_user_page_domain(self):
         """when the user domain has dashes in it"""
         with patch("bookwyrm.models.user.set_remote_server"):
-            self.remote_user = models.User.objects.create_user(
+            models.User.objects.create_user(
                 "nutria",
                 "",
                 "nutriaword",