From ab3fb4d5550b86ecad7ea1561ac41efdada2873c Mon Sep 17 00:00:00 2001 From: Mouse Reeve Date: Thu, 20 May 2021 16:32:44 -0700 Subject: [PATCH 1/3] Adds test for search with no query --- bookwyrm/tests/views/test_search.py | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/bookwyrm/tests/views/test_search.py b/bookwyrm/tests/views/test_search.py index a6d7c36e..5a5639d8 100644 --- a/bookwyrm/tests/views/test_search.py +++ b/bookwyrm/tests/views/test_search.py @@ -53,6 +53,18 @@ class Views(TestCase): self.assertEqual(data[0]["title"], "Test Book") self.assertEqual(data[0]["key"], "https://%s/book/%d" % (DOMAIN, self.book.id)) + def test_search_no_query(self): + """just the search page""" + view = views.Search.as_view() + # we need a connector for this, sorry + request = self.factory.get("") + with patch("bookwyrm.views.search.is_api_request") as is_api: + is_api.return_value = False + response = view(request) + self.assertIsInstance(response, TemplateResponse) + response.render() + + def test_search_books(self): """searches remote connectors""" view = views.Search.as_view() From a8a8398cf8988cea8716dece7b2ebb47edb47a76 Mon Sep 17 00:00:00 2001 From: Mouse Reeve Date: Thu, 20 May 2021 16:34:32 -0700 Subject: [PATCH 2/3] Fixes search null state view --- bookwyrm/views/search.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bookwyrm/views/search.py b/bookwyrm/views/search.py index 558c2039..e7b538e4 100644 --- a/bookwyrm/views/search.py +++ b/bookwyrm/views/search.py @@ -36,7 +36,7 @@ class Search(View): ) return JsonResponse([r.json() for r in book_results], safe=False) - if not search_type: + if query and not search_type: search_type = "user" if "@" in query else "book" endpoints = { From 6cadba78fee2d0640cf749b6bb459d82a316bdfd Mon Sep 17 00:00:00 2001 From: Mouse Reeve Date: Thu, 20 May 2021 16:38:12 -0700 Subject: [PATCH 3/3] Python formatting --- bookwyrm/tests/views/test_search.py | 1 - 1 file changed, 1 deletion(-) diff --git a/bookwyrm/tests/views/test_search.py b/bookwyrm/tests/views/test_search.py index 5a5639d8..ab2c910d 100644 --- a/bookwyrm/tests/views/test_search.py +++ b/bookwyrm/tests/views/test_search.py @@ -64,7 +64,6 @@ class Views(TestCase): self.assertIsInstance(response, TemplateResponse) response.render() - def test_search_books(self): """searches remote connectors""" view = views.Search.as_view()