[profile] Various HTML fixes:

- Wrap block level elements within block level elements, not inline.
- Avoid empty blocks.
- Change `<hr>` in lists into allowed type of children.
- Fix duplicated ID (some change that was not propagated across the template?).
- Make the anchor optional in the navbar (interactive elements (`a`, `input`, `button`…) should not appear into other interactive elements).
- Remove redundant `role` on main navigation.
- Make the modal a modal with `role="dialog".
- Use `button` instead of form-less `label`.

bookwyrm/templates/snippets/shelf_selector.html

@@ -18,7 +18,7 @@
 </li>
 {% endif %}
 {% endfor %}
-<hr class="navbar-divider">
+<li class="navbar-divider" role="presentation"></li>
 <li>
     <form class="dropdown-item pt-0 pb-0" name="shelve" action="/unshelve/" method="post">
         {% csrf_token %}

bookwyrm/templates/snippets/status/status_content.html

@@ -3,10 +3,12 @@
 <div class="block">
     {% if status.status_type == 'Review' %}
     <div>
+        {% if status.name %}
         <h3 class="title is-5 has-subtitle">
-            {% if status.name %}<span dir="auto">{{ status.name }}</span><br>{% endif %}
+            {{ status.name | escape }}
         </h3>
-        <p class="subtitle">{% include 'snippets/stars.html' with rating=status.rating %}</p>
+        {% endif %}
+        {% include 'snippets/stars.html' with rating=status.rating %}
     </div>
     {% endif %}
 
@@ -35,7 +37,7 @@
         {% if status.content and status.status_type != 'GeneratedNote' and status.status_type != 'Boost' %}
         {% include 'snippets/trimmed_text.html' with full=status.content|safe %}
         {% endif %}
-        {% if status.attachments %}
+        {% if status.attachments.all %}
         <div class="block">
             <div class="columns">
                 {% for attachment in status.attachments.all %}

bookwyrm/templates/snippets/trimmed_text.html

@@ -8,19 +8,29 @@
 {% with full|to_markdown|safe|truncatewords_html:60 as trimmed %}
 {% if trimmed != full %}
 <div id="hide-full-{{ uuid }}">
-    <div class="content" id="trimmed-{{ uuid }}"><span dir="auto">{{ trimmed }}</span>
-        {% trans "Show more" as button_text %}
-        {% include 'snippets/toggle/open_button.html' with text=button_text controls_text="full" controls_uid=uuid class="is-small" %}
+    <div class="content" id="trimmed-{{ uuid }}">
+        <p dir="auto">{{ trimmed }}</p>
+
+        <div>
+            {% trans "Show more" as button_text %}
+            {% include 'snippets/toggle/open_button.html' with text=button_text controls_text="full" controls_uid=uuid class="is-small" %}
+        </div>
     </div>
 </div>
 <div id="full-{{ uuid }}" class="hidden">
-    <div class="content"><span dir="auto">{{ full }}</span>
-        {% trans "Show less" as button_text %}
-        {% include 'snippets/toggle/close_button.html' with text=button_text controls_text="full" controls_uid=uuid class="is-small" %}
+    <div class="content">
+        <div dir="auto">{{ full }}</div>
+
+        <div>
+            {% trans "Show less" as button_text %}
+            {% include 'snippets/toggle/close_button.html' with text=button_text controls_text="full" controls_uid=uuid class="is-small" %}
+        </div>
     </div>
 </div>
 {% else %}
-<div class="content"><span dir="auto">{{ full }}</span></div>
+<div class="content">
+    <div dir="auto">{{ full }}</div>
+</div>
 {% endif %}
 {% endwith %}
 

bookwyrm/templates/snippets/username.html

@@ -1,2 +1,15 @@
+{% spaceless %}
 {% load bookwyrm_tags %}
-<a href="{{ user.local_path }}" class="user">{% if user.name %}{{ user.name }}{% else %}{{ user | username }}{% endif %}</a>{% if possessive %}'s{% endif %}{% if show_full and user.name or show_full and user.localname %} ({{ user.username }}){% endif %}
+
+
+<{% if anchor %}a href="{{ user.local_path }}"{% else %}span{% endif %} class="user"
+>
+    {{ user.name|default:user|username }}
+</a>
+
+{% if possessive %}'s{% endif %}
+
+{% if show_full and user.name or show_full and user.localname %}
+ ({{ user.username }})
+{% endif %}
+{% endspaceless %}