Merge pull request #1490 from hughrun/bookwyrm-groups

Bookwyrm groups

bookwyrm/tests/models/test_group.py

@@ -0,0 +1,135 @@
+""" testing models """
+from unittest.mock import patch
+from django.test import TestCase
+
+from bookwyrm import models, settings
+
+
+@patch("bookwyrm.models.activitypub_mixin.broadcast_task.delay")
+class Group(TestCase):
+    """some activitypub oddness ahead"""
+
+    def setUp(self):
+        """Set up for tests"""
+
+        with patch("bookwyrm.suggested_users.rerank_suggestions_task.delay"), patch(
+            "bookwyrm.activitystreams.populate_stream_task.delay"
+        ):
+            self.owner_user = models.User.objects.create_user(
+                "mouse", "mouse@mouse.mouse", "mouseword", local=True, localname="mouse"
+            )
+
+        with patch("bookwyrm.suggested_users.rerank_suggestions_task.delay"), patch(
+            "bookwyrm.activitystreams.populate_stream_task.delay"
+        ):
+            self.rat = models.User.objects.create_user(
+                "rat", "rat@rat.rat", "ratword", local=True, localname="rat"
+            )
+
+        with patch("bookwyrm.suggested_users.rerank_suggestions_task.delay"), patch(
+            "bookwyrm.activitystreams.populate_stream_task.delay"
+        ):
+            self.badger = models.User.objects.create_user(
+                "badger",
+                "badger@badger.badger",
+                "badgerword",
+                local=True,
+                localname="badger",
+            )
+
+        with patch("bookwyrm.suggested_users.rerank_suggestions_task.delay"), patch(
+            "bookwyrm.activitystreams.populate_stream_task.delay"
+        ):
+            self.capybara = models.User.objects.create_user(
+                "capybara",
+                "capybara@capybara.capybara",
+                "capybaraword",
+                local=True,
+                localname="capybara",
+            )
+
+        self.public_group = models.Group.objects.create(
+            name="Public Group",
+            description="Initial description",
+            user=self.owner_user,
+            privacy="public",
+        )
+
+        self.private_group = models.Group.objects.create(
+            name="Private Group",
+            description="Top secret",
+            user=self.owner_user,
+            privacy="direct",
+        )
+
+        self.followers_only_group = models.Group.objects.create(
+            name="Followers Group",
+            description="No strangers",
+            user=self.owner_user,
+            privacy="followers",
+        )
+
+        models.GroupMember.objects.create(group=self.private_group, user=self.badger)
+        models.GroupMember.objects.create(
+            group=self.followers_only_group, user=self.badger
+        )
+        models.GroupMember.objects.create(group=self.public_group, user=self.capybara)
+
+    def test_group_members_can_see_followers_only_groups(self, _):
+        """follower-only group should not be excluded from group listings for group members viewing"""
+
+        rat_groups = models.Group.privacy_filter(self.rat).all()
+        badger_groups = models.Group.privacy_filter(self.badger).all()
+
+        self.assertFalse(self.followers_only_group in rat_groups)
+        self.assertTrue(self.followers_only_group in badger_groups)
+
+    def test_group_members_can_see_private_groups(self, _):
+        """direct privacy group should not be excluded from group listings for group members viewing"""
+
+        rat_groups = models.Group.privacy_filter(self.rat).all()
+        badger_groups = models.Group.privacy_filter(self.badger).all()
+
+        self.assertFalse(self.private_group in rat_groups)
+        self.assertTrue(self.private_group in badger_groups)
+
+    def test_group_members_can_see_followers_only_lists(self, _):
+        """follower-only group booklists should not be excluded from group booklist listing for group members who do not follower list owner"""
+
+        with patch("bookwyrm.models.activitypub_mixin.broadcast_task.delay"):
+            followers_list = models.List.objects.create(
+                name="Followers List",
+                curation="group",
+                privacy="followers",
+                group=self.public_group,
+                user=self.owner_user,
+            )
+
+        rat_lists = models.List.privacy_filter(self.rat).all()
+        badger_lists = models.List.privacy_filter(self.badger).all()
+        capybara_lists = models.List.privacy_filter(self.capybara).all()
+
+        self.assertFalse(followers_list in rat_lists)
+        self.assertFalse(followers_list in badger_lists)
+        self.assertTrue(followers_list in capybara_lists)
+
+    def test_group_members_can_see_private_lists(self, _):
+        """private group booklists should not be excluded from group booklist listing for group members"""
+
+        with patch("bookwyrm.models.activitypub_mixin.broadcast_task.delay"):
+
+            private_list = models.List.objects.create(
+                name="Private List",
+                privacy="direct",
+                curation="group",
+                group=self.public_group,
+                user=self.owner_user,
+            )
+
+        rat_lists = models.List.privacy_filter(self.rat).all()
+        badger_lists = models.List.privacy_filter(self.badger).all()
+        capybara_lists = models.List.privacy_filter(self.capybara).all()
+
+        self.assertFalse(private_list in rat_lists)
+        self.assertFalse(private_list in badger_lists)
+        self.assertTrue(private_list in capybara_lists)

bookwyrm/tests/views/test_group.py

@@ -0,0 +1,119 @@
+""" test for app action functionality """
+from unittest.mock import patch
+from django.contrib.auth import decorators
+
+from django.template.response import TemplateResponse
+from django.test import TestCase
+from django.test.client import RequestFactory
+
+from bookwyrm import models, views, forms
+from bookwyrm.tests.validate_html import validate_html
+
+
+@patch("bookwyrm.models.activitypub_mixin.broadcast_task.delay")
+class GroupViews(TestCase):
+    """view group and edit details"""
+
+    def setUp(self):
+        """we need basic test data and mocks"""
+        self.factory = RequestFactory()
+        with patch("bookwyrm.suggested_users.rerank_suggestions_task.delay"), patch(
+            "bookwyrm.activitystreams.populate_stream_task.delay"
+        ):
+            self.local_user = models.User.objects.create_user(
+                "mouse@local.com",
+                "mouse@mouse.mouse",
+                "password",
+                local=True,
+                localname="mouse",
+            )
+
+            self.testgroup = models.Group.objects.create(
+                name="Test Group",
+                description="Initial description",
+                user=self.local_user,
+                privacy="public",
+            )
+            self.membership = models.GroupMember.objects.create(
+                group=self.testgroup, user=self.local_user
+            )
+
+        models.SiteSettings.objects.create()
+
+    def test_group_get(self, _):
+        """there are so many views, this just makes sure it LOADS"""
+        view = views.Group.as_view()
+        request = self.factory.get("")
+        request.user = self.local_user
+        result = view(request, group_id=self.testgroup.id)
+        self.assertIsInstance(result, TemplateResponse)
+        validate_html(result.render())
+        self.assertEqual(result.status_code, 200)
+
+    def test_usergroups_get(self, _):
+        """there are so many views, this just makes sure it LOADS"""
+        view = views.UserGroups.as_view()
+        request = self.factory.get("")
+        request.user = self.local_user
+        result = view(request, username="mouse@local.com")
+        self.assertIsInstance(result, TemplateResponse)
+        validate_html(result.render())
+        self.assertEqual(result.status_code, 200)
+
+    @patch("bookwyrm.suggested_users.SuggestedUsers.get_suggestions")
+    def test_findusers_get(self, *_):
+        """there are so many views, this just makes sure it LOADS"""
+        view = views.FindUsers.as_view()
+        request = self.factory.get("")
+        request.user = self.local_user
+        result = view(request, group_id=self.testgroup.id)
+        self.assertIsInstance(result, TemplateResponse)
+        validate_html(result.render())
+        self.assertEqual(result.status_code, 200)
+
+    def test_group_create(self, _):
+        """create group view"""
+        view = views.UserGroups.as_view()
+        request = self.factory.post(
+            "",
+            {
+                "name": "A group",
+                "description": "wowzers",
+                "privacy": "unlisted",
+                "user": self.local_user.id,
+            },
+        )
+        request.user = self.local_user
+        result = view(request, "username")
+
+        self.assertEqual(result.status_code, 302)
+        new_group = models.Group.objects.filter(name="A group").get()
+        self.assertEqual(new_group.description, "wowzers")
+        self.assertEqual(new_group.privacy, "unlisted")
+        self.assertTrue(
+            models.GroupMember.objects.filter(
+                group=new_group, user=self.local_user
+            ).exists()
+        )
+
+    def test_group_edit(self, _):
+        """test editing a "group" database entry"""
+
+        view = views.Group.as_view()
+        request = self.factory.post(
+            "",
+            {
+                "name": "Updated Group name",
+                "description": "wow",
+                "privacy": "direct",
+                "user": self.local_user.id,
+            },
+        )
+        request.user = self.local_user
+
+        result = view(request, group_id=self.testgroup.id)
+        self.assertEqual(result.status_code, 302)
+        self.testgroup.refresh_from_db()
+        self.assertEqual(self.testgroup.name, "Updated Group name")
+        self.assertEqual(self.testgroup.description, "wow")
+        self.assertEqual(self.testgroup.privacy, "direct")