code cleanup

This commit is contained in:
Hugh Rundle 2021-11-20 19:19:51 +11:00
parent b406a03533
commit a3270551f9
No known key found for this signature in database
GPG Key ID: CD23D6039184286B
4 changed files with 6 additions and 2 deletions

View File

@ -93,8 +93,10 @@ let StatusCache = new class {
if (response.headers.get("forceReload")) { if (response.headers.get("forceReload")) {
BookWyrm.addRemoveClass(form, 'is-processing', true); BookWyrm.addRemoveClass(form, 'is-processing', true);
trigger.setAttribute('disabled', null); trigger.setAttribute('disabled', null);
return location.reload(); return location.reload();
} }
if (!response.ok) { if (!response.ok) {
throw new Error(); throw new Error();
} }

View File

@ -17,6 +17,7 @@ from .helpers import load_date_in_user_tz_as_utc
@method_decorator(login_required, name="dispatch") @method_decorator(login_required, name="dispatch")
# pylint: disable=no-self-use # pylint: disable=no-self-use
# pylint: disable=too-many-return-statements
class ReadingStatus(View): class ReadingStatus(View):
"""consider reading a book""" """consider reading a book"""

View File

@ -94,8 +94,8 @@ def shelve(request):
@require_POST @require_POST
def unshelve(request, referer=None, book_id=False): def unshelve(request, referer=None, book_id=False):
"""remove a book from a user's shelf""" """remove a book from a user's shelf"""
id = book_id if book_id else request.POST.get("book") identity = book_id if book_id else request.POST.get("book")
book = get_object_or_404(models.Edition, id=id) book = get_object_or_404(models.Edition, id=identity)
shelf_book = get_object_or_404( shelf_book = get_object_or_404(
models.ShelfBook, book=book, shelf__id=request.POST["shelf"] models.ShelfBook, book=book, shelf__id=request.POST["shelf"]
) )

View File

@ -54,6 +54,7 @@ class CreateStatus(View):
data = {"book": book} data = {"book": book}
return TemplateResponse(request, "compose.html", data) return TemplateResponse(request, "compose.html", data)
# pylint: disable=too-many-branches
def post(self, request, status_type, existing_status_id=None): def post(self, request, status_type, existing_status_id=None):
"""create status of whatever type""" """create status of whatever type"""
created = not existing_status_id created = not existing_status_id