yul/bookwyrm-mastodon
1
1
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixes logic error in detecting changed fields when serializing

Browse Source
This commit is contained in:
Mouse Reeve 2021-08-03 12:21:11 -07:00
parent b059cbdd18
commit ebc0680288
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
bookwyrm/models/fields.py
View File

@ -80,7 +80,7 @@ class ActivitypubFieldMixin:
return False return False
# the field is unchanged # the field is unchanged
if getattr(instance, self.name) == formatted: if hasattr(instance, self.name) and getattr(instance, self.name) == formatted:
return False return False
setattr(instance, self.name, formatted) setattr(instance, self.name, formatted)

1
bookwyrm/tests/activitypub/test_base_activity.py
View File

@ -21,6 +21,7 @@ from bookwyrm import models
@patch("bookwyrm.activitystreams.ActivityStream.add_status") @patch("bookwyrm.activitystreams.ActivityStream.add_status")
@patch("bookwyrm.suggested_users.rerank_user_task.delay") @patch("bookwyrm.suggested_users.rerank_user_task.delay")
@patch("bookwyrm.suggested_users.remove_user_task.delay")
@patch("bookwyrm.suggested_users.rerank_suggestions_task.delay") @patch("bookwyrm.suggested_users.rerank_suggestions_task.delay")
class BaseActivity(TestCase): class BaseActivity(TestCase):
"""the super class for model-linked activitypub dataclasses""" """the super class for model-linked activitypub dataclasses"""