From f6c3e581b95c2f1b3acbf62b9595fc9b9def1618 Mon Sep 17 00:00:00 2001
From: Fabien Basmaison <contact@arkhi.org>
Date: Tue, 6 Apr 2021 09:11:27 +0200
Subject: [PATCH] =?UTF-8?q?[assets]=20Replace=20`Array.from(document.getEl?=
 =?UTF-8?q?ementsByClassName(=E2=80=A6))`=20by=20`querySelectorAll(?=
 =?UTF-8?q?=E2=80=A6)`.?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 bookwyrm/static/js/bookwyrm.js     | 10 ++++++----
 bookwyrm/static/js/localstorage.js |  2 +-
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/bookwyrm/static/js/bookwyrm.js b/bookwyrm/static/js/bookwyrm.js
index a4149c6f..7d542747 100644
--- a/bookwyrm/static/js/bookwyrm.js
+++ b/bookwyrm/static/js/bookwyrm.js
@@ -7,11 +7,11 @@ window.onload = function() {
         .forEach(t => t.onclick = toggleAction);
 
     // javascript interactions (boost/fav)
-    Array.from(document.getElementsByClassName('interaction'))
+    document.querySelectorAll('.interaction')
         .forEach(t => t.onsubmit = interact);
 
     // handle aria settings on menus
-    Array.from(document.getElementsByClassName('pulldown-menu'))
+    document.querySelectorAll('.pulldown-menu')
         .forEach(t => t.onclick = toggleMenu);
 
     // hidden submit button in a form
@@ -26,7 +26,7 @@ window.onload = function() {
     document.querySelectorAll('[data-back]')
         .forEach(t => t.onclick = back);
 
-    Array.from(document.getElementsByClassName('tab-group'))
+    document.querySelectorAll('.tab-group')
         .forEach(t => new TabGroup(t));
 };
 
@@ -103,7 +103,9 @@ function interact(e) {
     e.preventDefault();
     ajaxPost(e.target);
     var identifier = e.target.getAttribute('data-id');
-    Array.from(document.getElementsByClassName(identifier))
+    // @todo This should be `querySelector`, unless there are duplicated IDs,
+    //       which is a problem in itself.
+    document.querySelectorAll(`#${identifier}`)
         .forEach(t => addRemoveClass(t, 'hidden', t.className.indexOf('hidden') == -1));
 }
 
diff --git a/bookwyrm/static/js/localstorage.js b/bookwyrm/static/js/localstorage.js
index 5104b44a..514d8748 100644
--- a/bookwyrm/static/js/localstorage.js
+++ b/bookwyrm/static/js/localstorage.js
@@ -24,5 +24,5 @@ document.querySelectorAll('[data-hide]')
     .forEach(t => setDisplay(t));
 
 // update localstorage
-Array.from(document.getElementsByClassName('set-display'))
+document.querySelectorAll('.set-display')
     .forEach(t => t.onclick = updateDisplay);