Commit Graph

4181 Commits

Author SHA1 Message Date
Mouse Reeve 7b89014e7b Updates image fields tests 2021-11-28 08:24:00 -08:00
Mouse Reeve 54cef421e2 Fixes checking if image fields are already set 2021-11-28 07:57:27 -08:00
Hugh Rundle 6abf5d6910
add submit button to remote follow form 2021-11-28 21:48:03 +11:00
Hugh Rundle e9bb2a04a4
code cleanup 2021-11-28 21:38:28 +11:00
Hugh Rundle f828f36cc5
show popup for remote follow 2021-11-28 21:16:57 +11:00
Hugh Rundle 6e7d23c1ae
add remote follow button 2021-11-28 20:09:29 +11:00
Hugh Rundle 2e428e6ea1
add remote follow templates 2021-11-28 20:08:54 +11:00
Hugh Rundle e275b98183
ostatus remote follow views 2021-11-28 16:56:21 +11:00
Hugh Rundle 610114b4eb
rearrange ostatus templates 2021-11-28 16:54:25 +11:00
Hugh Rundle d05e100421
update ostatus templates 2021-11-28 13:28:58 +11:00
Hugh Rundle f7c8f121b9
add remote follow ostatus templates 2021-11-28 12:43:29 +11:00
Hugh Rundle 9d52e3cf27
add ostatus subscribe to webfinger links 2021-11-27 18:32:50 +11:00
Hugh Rundle 1a37903583
remove unnecessary function call arg 2021-11-26 17:39:35 +11:00
Hugh Rundle a5efc798f8
clean up old vars 2021-11-26 17:30:27 +11:00
Hugh Rundle 951eb43aa6
bypass ajax for shelf_selector statuses 2021-11-26 17:16:26 +11:00
Hugh Rundle 5b67226571
forceReload prevents ajax submission
...instead of weird hacky workarounds forcing refreshes later.
2021-11-25 19:12:03 +11:00
Hugh Rundle b91915d316
change shelf var for shelf_selector in book view 2021-11-25 08:20:34 +11:00
Hugh Rundle c704c7eb8f
remove from any shelf in all books shelf view
- fixes removing book from 'all books' shelf erroring
- remove from any shelf item is on when in 'all books'
2021-11-25 07:38:08 +11:00
Joachim 7d24568dcd Update test_updates.py 2021-11-24 20:54:53 +01:00
Joachim 5f81be74cb Add test 2021-11-24 20:52:30 +01:00
Joachim 0001d6e92a PyLint 2021-11-24 19:04:14 +01:00
Joachim 8712b2fdab ESLint 2021-11-24 19:02:07 +01:00
Joachim db5e7a886a Handle count of notifications banner 2021-11-24 19:00:30 +01:00
Joachim 2ad37a22dd Move stream filter to helpers 2021-11-24 13:37:09 +01:00
Joachim 40e4591a24 Apply review suggestions 2021-11-24 11:59:45 +01:00
Mouse Reeve ad6c860951
Merge pull request #1627 from joachimesque/fix-preview-image-url
Don't change the preview image URL on update
2021-11-23 15:01:15 -08:00
Joachim 63e284dc41 Forgive me pylint 2021-11-22 18:59:46 +01:00
Joachim 47cfc2f157 Hardcode form 2021-11-22 18:52:57 +01:00
Hugh Rundle d8e83ffe82
moar code linting 2021-11-22 13:01:58 +11:00
Hugh Rundle a9d921cc06
code cleanup 2021-11-22 12:52:59 +11:00
Hugh Rundle 09c5a3861b
prefer English language sources for ISNI titles 2021-11-22 12:15:06 +11:00
Joachim 0b46db49a3 Fix pylint 2021-11-22 00:46:24 +01:00
Joachim bc7de410b7 Add migration 2021-11-22 00:33:08 +01:00
Joachim a0093a8a2e Add status type filters 2021-11-22 00:25:47 +01:00
Chad Nelson 6be9ac4f70 Abstract JS for multivalue form fields 2021-11-21 17:32:48 -05:00
Hugh Rundle fd3ed7fb8c
fix author is now class object not dict 2021-11-22 09:25:31 +11:00
Hugh Rundle 8691023fa9
display link to isni in author page when other identifiers missing 2021-11-22 09:24:05 +11:00
Hugh Rundle a218fa21ea Merge branch 'main' into isni-poc 2021-11-22 08:53:58 +11:00
Hugh Rundle fd2ade2313
refactor isni author enrichment
- use activitypub.Author instead of custom dict
- prefer to display "Author of [title]" from ISNI data instead of short description
- merge isni and db authors for edit_book display
- fix edit_book template to use changed data
- rename some functions in utils/isni.py
2021-11-22 08:49:22 +11:00
Hugh Rundle e2836d468d
don't use author name as deduplication field 2021-11-22 08:47:12 +11:00
Hugh Rundle 1e6e4b0f8d
use activitypub dataclass for isni authors
- add timeout to isni API call
- use activitypub.Author dataclass instead of bespoke dict
- display isni authors as "Author of" first title in ISNI record if possible
- sensible fallbacks if title info unavailable in isni record
2021-11-21 19:55:55 +11:00
Joachim ad6aaa6bc8 Update preview_images.py 2021-11-20 17:15:58 +01:00
Joachim f26a41bd10 Prevent empty file name 2021-11-20 17:10:29 +01:00
Joachim d74df047c5 Clean up file before saving 2021-11-20 16:59:05 +01:00
Joachim 40264e372d Update preview_images.py 2021-11-20 16:26:02 +01:00
Joachim 37508d2583 Update preview_images.py 2021-11-20 16:23:50 +01:00
Hugh Rundle e247e96832
remove incorrect comment 2021-11-20 19:34:37 +11:00
Hugh Rundle a3270551f9
code cleanup 2021-11-20 19:19:51 +11:00
Hugh Rundle b406a03533
don't persist form state in firefox
Fixes shelves not being disabled in dropdowns.
See https://stackoverflow.com/questions/5985839/bug-with-firefox-disabled-attribute-of-input-not-resetting-when-refreshing
2021-11-20 19:04:51 +11:00
Hugh Rundle 4b6f5c9f51
remove out of date comment 2021-11-20 19:03:57 +11:00
Hugh Rundle b273123708
code style 2021-11-20 16:06:16 +11:00
Hugh Rundle 12810d8e34
don't try to update non-existent readthroughs 2021-11-20 16:03:46 +11:00
Hugh Rundle af9768a2e3
force page reload when adding status from move button 2021-11-20 14:59:59 +11:00
Hugh Rundle 41862e854c
move from reading to editable shelf with logic that actually works 2021-11-20 13:57:37 +11:00
Hugh Rundle c6a2de3bbc
pass readthrough id to shelf_selector
- allows user to move book from a shelf to the 'Read' shelf using the move button.
2021-11-20 10:29:17 +11:00
Hugh Rundle 373cc2c762
active_shelf should always be a reading status shelf 2021-11-20 09:58:34 +11:00
Hugh Rundle a082121930
fix shelves not being unshelved if any shelf is read-status 2021-11-20 08:55:43 +11:00
Hugh Rundle 6951b52365
disallow moving to shelf already used 2021-11-20 08:18:43 +11:00
Hugh Rundle 9ffe4d340e
trigger reading status modals from move button
- unhide reading status shelves
- trigger modals when moving to a read status shelf
- force page refresh when using move button
2021-11-20 08:06:13 +11:00
Mouse Reeve 417f09690f Include admin and moderator in reporting email 2021-11-18 15:08:00 -08:00
Mouse Reeve 21c90ac99e Use groups not permissions 2021-11-18 14:51:00 -08:00
Mouse Reeve 3787a31c67 Updates image helpers on site 2021-11-18 14:39:22 -08:00
Mouse Reeve 41dd915d7f Email templates 2021-11-17 20:22:00 -08:00
Mouse Reeve 9961a08c93 Adds Galician locale 2021-11-17 10:02:39 -08:00
Mouse Reeve e3fec5885a Fixes logic on nodeinfo page 2021-11-16 16:20:29 -08:00
Mouse Reeve 6dd7eebd98 Fixes tests 2021-11-16 10:16:28 -08:00
Mouse Reeve 50ca16a46f Merge branch 'main' into inventaire-connector-tests 2021-11-16 09:59:50 -08:00
Hugh Rundle 8658e36ca8
code formatting 2021-11-16 20:40:22 +11:00
Hugh Rundle 03c59f2431
improve security on isni url 2021-11-16 20:37:37 +11:00
Hugh Rundle 9ca18d9cd4
isni utils cleanup
Utilises the requests module's built in functionality to pass params as a dict
which is url encoded by requests.
2021-11-16 20:35:47 +11:00
Hugh Rundle ec39346e67
check shelf.editable instead of custom filter 2021-11-16 19:26:49 +11:00
Mouse Reeve 2968145627
Merge pull request #1614 from bookwyrm-social/outbox-error
Safer call to get preview image or books
2021-11-15 13:47:00 -08:00
Mouse Reeve f22ae23574 Safer call to get preview image or books 2021-11-15 13:34:02 -08:00
Mouse Reeve 58f63280fd
Merge pull request #1612 from bookwyrm-social/lithuanian-space
Preserve spaces between links
2021-11-15 12:11:36 -08:00
Mouse Reeve 5e5cb26290 Preserve spaces between links 2021-11-15 11:47:39 -08:00
Mouse Reeve bcfe13bb4e Sort followers/following lists by if you follow the user 2021-11-15 11:28:43 -08:00
Mouse Reeve 7d66013b52 Adds Lithuanian to the user options 2021-11-15 10:26:00 -08:00
Mouse Reeve afbc742f47
Merge pull request #1600 from bookwyrm-social/import-field-names
Refactors import process
2021-11-15 09:59:54 -08:00
Mouse Reeve 30afe42b3a Removes extra space in progress bar 2021-11-15 09:41:05 -08:00
Mouse Reeve 83e468a4f8 Fixes "indeterminate" state of progress indicator on screen reader 2021-11-15 09:34:36 -08:00
Mouse Reeve 77ee1147d5 Adds return_first tests to book_search 2021-11-15 09:03:00 -08:00
Hugh Rundle eab2ec0ffd
code cleanup in is_shelf_type template tag 2021-11-15 21:19:16 +11:00
Hugh Rundle 168a2488e2
refactor shelf activity on book page
- disallow moving from custom shelf to a reading status shelf with shelf_selector
- always use shelve_button for moving books from a reading status shelf
- redesign shelf information as a list of boxes
2021-11-15 20:59:22 +11:00
Mouse Reeve 8612cf654d Invalid href 2021-11-14 11:31:47 -08:00
Mouse Reeve 14e2960d06 Update legacy jobs 2021-11-14 10:58:46 -08:00
Mouse Reeve 9f6796bbf5 Safer request for normalized data 2021-11-14 10:29:12 -08:00
Mouse Reeve 31f3351854 Fixes bug comparing dates to nonetype 2021-11-14 10:22:26 -08:00
Mouse Reeve 8cede05d32 Retry hanging items 2021-11-14 10:20:14 -08:00
Mouse Reeve f92863ad3e Notify when import completes 2021-11-14 09:56:23 -08:00
Mouse Reeve 47b98ad0d9 Track completed items on job 2021-11-14 09:04:12 -08:00
Mouse Reeve 9e673834dc Check for duplicates 2021-11-14 08:35:16 -08:00
Mouse Reeve 6cca3f9772 Updates test data 2021-11-14 07:57:13 -08:00
Mouse Reeve 2748e0a824 Check for existing reviews/ratings on import items 2021-11-14 07:50:19 -08:00
Mouse Reeve bdc3f6828b Python formatting 2021-11-14 07:11:48 -08:00
Mouse Reeve c614f638fd Merge branch 'import-field-names' of github.com:bookwyrm-social/bookwyrm into import-field-names 2021-11-14 07:06:48 -08:00
Hugh Rundle 3357953a53
whoops forgot inventaire_id 2021-11-14 21:26:23 +11:00
Hugh Rundle 8495cf8a45
don't delete non-form data when editing authors
fixes #1584

This is a temporary fix. As Mouse has suggested, ultimately it would be good to re-import data from one or more of the linked data sources if there is anything missing.
2021-11-14 21:21:37 +11:00
Mouse Reeve 32d0d8d027 Expand librarything csv processing tests 2021-11-13 13:04:54 -08:00
Mouse Reeve 7f06ee3844 Fixes getting isbn for librarything imports 2021-11-13 12:46:27 -08:00
Mouse Reeve fb91c33682 Fixes isbn assignment for goodreads 2021-11-13 12:24:16 -08:00
Mouse Reeve a9622942cd Test correctly adding goodreads isbns 2021-11-13 12:11:07 -08:00
Mouse Reeve 8b7720c8b8 Use "reject" instead of "delete" on review page 2021-11-13 11:54:28 -08:00
Mouse Reeve 712d8ecfb4 Don't show empty stars when there's no review 2021-11-13 11:52:08 -08:00
Mouse Reeve 1e46de4c9d Associate imported review with import item 2021-11-13 11:44:05 -08:00
Mouse Reeve 1e2dca402b Adds null value to breadcrumb links 2021-11-13 11:40:19 -08:00
Mouse Reeve 644d969330 Fixes importer tests 2021-11-13 11:22:07 -08:00
Mouse Reeve 4dae851da0 Adds breadcrumbs 2021-11-13 11:18:10 -08:00
Mouse Reeve e77eea9c81 Adds tests for import manual review 2021-11-13 10:52:11 -08:00
Mouse Reeve c3156a1de5 Fixes import path in test 2021-11-13 10:22:28 -08:00
Mouse Reeve 628f104b13 Separates out imports views tests 2021-11-13 10:16:25 -08:00
Mouse Reeve 232e051dcb Fixes import job creates in tests 2021-11-13 10:16:05 -08:00
Mouse Reeve 3bdda973bc Creates subdirectory for import views tests 2021-11-13 09:52:09 -08:00
Mouse Reeve d3f23b4a0a Updates calls in tests 2021-11-13 09:50:56 -08:00
Mouse Reeve 659d0f19eb Improves import table ui
adds table container, plays with display a bit
2021-11-13 09:43:52 -08:00
Mouse Reeve 60fb1ac2e6 More flexible templates 2021-11-13 09:34:10 -08:00
Mouse Reeve acc32d579e Preview review in import preview 2021-11-13 09:22:35 -08:00
Mouse Reeve c245ad09bb Make sure book is in the right format 2021-11-13 09:07:50 -08:00
Mouse Reeve 08f4ad6cd4 Fixes call to import task 2021-11-13 09:02:42 -08:00
Mouse Reeve 40fff02eec Approve or delete import guesses 2021-11-12 17:10:47 -08:00
Mouse Reeve 221cde9be4 Adds manual review view 2021-11-12 16:24:45 -08:00
Mouse Reeve 9bff27e61f Separate import classes into files 2021-11-12 15:50:33 -08:00
Mouse Reeve be26e8363a Create import directory 2021-11-12 15:43:15 -08:00
Mouse Reeve 5558ed810e Show manual review flag 2021-11-12 15:40:07 -08:00
Mouse Reeve 6a5a598345 Raise errors when import items fail
This should make is way easier to debug
2021-11-12 15:17:01 -08:00
Mouse Reeve b784dcdb46 Removes uninformative test 2021-11-12 15:07:26 -08:00
Mouse Reeve 1d0f6d5243 Python formatting 2021-11-12 15:06:23 -08:00
Mouse Reeve 6161f60695 Use normalized data in table 2021-11-12 14:54:20 -08:00
Mouse Reeve 61eaf51310 Fixes html validity 2021-11-12 14:49:24 -08:00
Mouse Reeve e09c02017c Fixes title/author search handling 2021-11-12 14:46:39 -08:00
Mouse Reeve 60c777ed49 Updates tests 2021-11-12 14:41:25 -08:00
Mouse Reeve d8197cdcfa Indicate retry on status page 2021-11-12 14:38:41 -08:00
Mouse Reeve a65f07e0bf Adds retry page 2021-11-12 14:36:28 -08:00
Mouse Reeve 2a84c0a370 title author search already working correctly with return first 2021-11-12 13:59:54 -08:00
Mouse Reeve 80c1954aa3 Fixes first_search_result behavior 2021-11-12 13:48:31 -08:00
Mouse Reeve 1e8269b6c9 Refactors import status view 2021-11-12 13:10:52 -08:00
Mouse Reeve 309d289a65 A few more mocks 2021-11-12 10:49:49 -08:00
Mouse Reeve cad5a128ac Fixes call to add_status signal 2021-11-12 10:19:13 -08:00
Mouse Reeve e6a251fdad Updates mocks across tests 2021-11-12 10:07:38 -08:00
Mouse Reeve f71ef286b6 Updates mocks 2021-11-12 08:55:47 -08:00
Mouse Reeve 3190ef4346 Deprioritize adding old statuses to timelines 2021-11-11 19:19:23 -08:00
Mouse Reeve 9fee860b00 Adds enum for queue names 2021-11-11 19:10:22 -08:00
Mouse Reeve 6aa57d4d34 Set queue for broadcast task 2021-11-11 19:00:01 -08:00
Mouse Reeve c33d791974 adds tests for new task system 2021-11-11 15:17:32 -08:00
Mouse Reeve 908c9dc689 Use many small tasks instead of one big task 2021-11-11 14:42:29 -08:00
Mouse Reeve f0ce236ffc Removes unused code 2021-11-11 14:28:49 -08:00
Mouse Reeve be94818a10 Fixes views tests 2021-11-11 14:27:29 -08:00
Mouse Reeve 915c41f59f Merge branch 'main' into import-field-names 2021-11-11 14:08:16 -08:00
Mouse Reeve 50ab4e8248 Updates model tests 2021-11-11 14:08:00 -08:00
Mouse Reeve c37472b484
Merge pull request #1599 from bookwyrm-social/remove-serialize-image-helper
Remove serialize image helper
2021-11-11 13:53:17 -08:00
Mouse Reeve ffcaef0559 Python formatting 2021-11-11 13:39:58 -08:00
Mouse Reeve 8c4e8361f2 Fixes tests 2021-11-11 13:35:56 -08:00
Mouse Reeve c744faf393 Fixes dictionary list html validity 2021-11-11 13:00:34 -08:00
Mouse Reeve d807774c2d Fixes label for privacy field 2021-11-11 12:53:48 -08:00
Mouse Reeve efcf7824dd iUpdates storygraph tests 2021-11-11 12:39:12 -08:00
Mouse Reeve 5967834805 Adds migration 2021-11-11 12:29:51 -08:00
Mouse Reeve f3bcced0a0 Adds shelf mappings 2021-11-11 12:29:38 -08:00
Mouse Reeve 147dd95e8d Removes unused import 2021-11-11 11:59:15 -08:00
Mouse Reeve a95e031140 Validate html in unit tests 2021-11-11 11:33:12 -08:00
Mouse Reeve 4d574a3536 Process dates in librarything import 2021-11-11 09:54:36 -08:00
Mouse Reeve 20baf9385d Updates goodreads tests 2021-11-11 09:22:44 -08:00
Mouse Reeve 4ccd9fc633 Use generalized mappings to handle import 2021-11-10 16:49:54 -08:00
Mouse Reeve 81450ac2d5
Merge pull request #1597 from bookwyrm-social/import-fixes
Don't broadcast imported reviews outside bookwyrm
2021-11-10 12:32:51 -08:00
Mouse Reeve 0736c7e160 Uses general names for fields in parsed csvs 2021-11-10 11:10:09 -08:00
Mouse Reeve 717da918cf Use social media preview images 2021-11-10 10:59:21 -08:00
Mouse Reeve d61595abb9 Clearer syntax 2021-11-10 10:50:05 -08:00
Mouse Reeve cf477a03ae Corrects broadcast flow for objects 2021-11-10 10:39:51 -08:00
Mouse Reeve 7e784fa705 Removes used import 2021-11-10 10:35:37 -08:00
Mouse Reeve 9815e9e100 Python formatting 2021-11-10 10:30:18 -08:00
Mouse Reeve 4f5d23e785 Replace image_serialzier helper with built-in serializers 2021-11-10 10:28:43 -08:00
Mouse Reeve d204e8dbb8
Merge pull request #1247 from joachimesque/image-absolute-url-getter
Add get_absolute_url to ImageField
2021-11-10 10:27:29 -08:00
Mouse Reeve 97a71f5e39 Cleans up software check syntax 2021-11-10 09:55:56 -08:00
Mouse Reeve 1b9d08414f Adds storygraph tests 2021-11-10 09:55:52 -08:00
Mouse Reeve aeef472ee1 Fixes flow in checking software for broadcast 2021-11-10 09:33:00 -08:00
Mouse Reeve 20c6a3ea1c Creates generic importer test file
And removes some tests that duplicate the generic tests
2021-11-10 09:32:53 -08:00
Hugh Rundle eb62474b97
fix broken book links in Discover 2021-11-10 22:04:19 +11:00
Hugh Rundle 3f6b0608b2
Show user and book names for reading actions in Discover
fixes #1596

This uses the same technique as #1572 to ensure read statuses from GeneratedNotes are translated.
2021-11-10 21:37:16 +11:00
Mouse Reeve e19c4620ce Don't broadcast imported reviews outside bookwyrm 2021-11-08 12:00:08 -08:00
Hugh Rundle dfe92a27c0
use shelf name if not default shelf
(instead of shelf.identifier)
2021-11-06 11:10:58 +11:00
Hugh Rundle d8098357e6
match page title to active shelf
resolves #1586
2021-11-06 10:53:41 +11:00
Hugh Rundle c3ba7ba547 pylint Y U like this? 2021-11-01 20:04:25 +11:00
Hugh Rundle 6556090524 Update existing authors when isni data available
When an existing author is selected as a new author when editing a book,
if they have an ISNI ID recorded we check the record and augment the local
database record from the ISNI data.

Also dedupes author aliases for this feature and when adding a completely
new author.
2021-11-01 19:50:49 +11:00
Hugh Rundle c845b7a5d0 code cleanup 2021-11-01 16:00:34 +11:00
Hugh Rundle 775470a852 normalise isnis
Some isnis are imported with spaces and some not.
This normalises them for comparison and creating URLs
2021-11-01 15:48:52 +11:00
Hugh Rundle 55ac80cc16 ugh pylint 2021-11-01 12:01:57 +11:00
Hugh Rundle 1533b55a32 lint code 2021-11-01 11:58:08 +11:00
Hugh Rundle b593b9c9d3 Display link to isni record on author page 2021-11-01 11:45:47 +11:00
Hugh Rundle 630f508ee4 code cleanup 2021-11-01 11:39:37 +11:00
Hugh Rundle 552980e208 select correct isni record when adding authors
The original implementation of this was so, so broken.
Now it's not.
2021-11-01 11:34:32 +11:00
Hugh Rundle 37148c5127 display isni bio with existing author name
If an existing author has an isni on record and it matches an author from the isni api call,
display the isni short description to aid with identifying the appropriate author.
2021-11-01 10:26:17 +11:00
Hugh Rundle 30a959dfce make pylint happy 2021-11-01 10:20:19 +11:00
Hugh Rundle 3cfd31f1fe hide isni authors if isni in local db
Check the authors suggested from the local DB for a matching ISNI when pulling authors from ISNI.
i.e. we do not want to suggest the same author twice when we *know* it is the same author.
2021-10-31 20:48:47 +11:00
Hugh Rundle bce5f3f3b5 populate new authors with isni data
If a user selects an author pulled from the ISNI service when editing a book, use any relevant data from ISNI to populate the new author record.

This includes
- bio
- aliases
- isni
- wikipedia url
- viaf
2021-10-31 17:58:15 +11:00
Hugh Rundle 45158a1c03 improve isni search logic
- skip ISNIs that aren't persons
- don't look for text values in non-existent nameTitle elements
2021-10-30 09:24:42 +11:00
Hugh Rundle 87ed6f8380 code formatting 2021-10-29 21:14:32 +11:00
Hugh Rundle d87e1b1567 fix encoding
The OCLC server claims that the xml payload is encoded as latin1 (ISO-8859-1).
This causes Requests to incorrectly encode things as latin1, when actually everything is (thank goodness) UTF-8.
We can fix it by just telling Requests that it is really UTF-8

With thanks to Tex Texin, creator of http://i18nqa.com/debug/utf8-debug.html
2021-10-29 21:00:35 +11:00
Hugh Rundle f2e4865adf check isni sources when editing book authors 2021-10-29 16:13:05 +11:00
Hugh Rundle 625cfac76f isni author lookup utility 2021-10-29 16:12:31 +11:00
Mouse Reeve d3e4c7e8d9 Removes change to boolean logic 2021-10-27 10:40:37 -07:00
Mouse Reeve 07446fa7d2 Adds more tests for the inventaire connector 2021-10-27 10:03:09 -07:00
Joachim 56fd147c88 Update test_status_model.py 2021-10-27 19:00:09 +02:00