d8e83ffe82
moar code linting
2021-11-22 13:01:58 +11:00
a9d921cc06
code cleanup
2021-11-22 12:52:59 +11:00
09c5a3861b
prefer English language sources for ISNI titles
2021-11-22 12:15:06 +11:00
0b46db49a3
Fix pylint
2021-11-22 00:46:24 +01:00
bc7de410b7
Add migration
2021-11-22 00:33:08 +01:00
a0093a8a2e
Add status type filters
2021-11-22 00:25:47 +01:00
6be9ac4f70
Abstract JS for multivalue form fields
2021-11-21 17:32:48 -05:00
fd3ed7fb8c
fix author is now class object not dict
2021-11-22 09:25:31 +11:00
8691023fa9
display link to isni in author page when other identifiers missing
2021-11-22 09:24:05 +11:00
a218fa21ea
Merge branch 'main' into isni-poc
2021-11-22 08:53:58 +11:00
fd2ade2313
refactor isni author enrichment
...
- use activitypub.Author instead of custom dict
- prefer to display "Author of [title]" from ISNI data instead of short description
- merge isni and db authors for edit_book display
- fix edit_book template to use changed data
- rename some functions in utils/isni.py
2021-11-22 08:49:22 +11:00
e2836d468d
don't use author name as deduplication field
2021-11-22 08:47:12 +11:00
1e6e4b0f8d
use activitypub dataclass for isni authors
...
- add timeout to isni API call
- use activitypub.Author dataclass instead of bespoke dict
- display isni authors as "Author of" first title in ISNI record if possible
- sensible fallbacks if title info unavailable in isni record
2021-11-21 19:55:55 +11:00
ad6aaa6bc8
Update preview_images.py
2021-11-20 17:15:58 +01:00
f26a41bd10
Prevent empty file name
2021-11-20 17:10:29 +01:00
d74df047c5
Clean up file before saving
2021-11-20 16:59:05 +01:00
40264e372d
Update preview_images.py
2021-11-20 16:26:02 +01:00
37508d2583
Update preview_images.py
2021-11-20 16:23:50 +01:00
e247e96832
remove incorrect comment
2021-11-20 19:34:37 +11:00
a3270551f9
code cleanup
2021-11-20 19:19:51 +11:00
b406a03533
don't persist form state in firefox
...
Fixes shelves not being disabled in dropdowns.
See https://stackoverflow.com/questions/5985839/bug-with-firefox-disabled-attribute-of-input-not-resetting-when-refreshing
2021-11-20 19:04:51 +11:00
4b6f5c9f51
remove out of date comment
2021-11-20 19:03:57 +11:00
b273123708
code style
2021-11-20 16:06:16 +11:00
12810d8e34
don't try to update non-existent readthroughs
2021-11-20 16:03:46 +11:00
af9768a2e3
force page reload when adding status from move button
2021-11-20 14:59:59 +11:00
41862e854c
move from reading to editable shelf with logic that actually works
2021-11-20 13:57:37 +11:00
c6a2de3bbc
pass readthrough id to shelf_selector
...
- allows user to move book from a shelf to the 'Read' shelf using the move button.
2021-11-20 10:29:17 +11:00
373cc2c762
active_shelf should always be a reading status shelf
2021-11-20 09:58:34 +11:00
a082121930
fix shelves not being unshelved if any shelf is read-status
2021-11-20 08:55:43 +11:00
6951b52365
disallow moving to shelf already used
2021-11-20 08:18:43 +11:00
9ffe4d340e
trigger reading status modals from move button
...
- unhide reading status shelves
- trigger modals when moving to a read status shelf
- force page refresh when using move button
2021-11-20 08:06:13 +11:00
417f09690f
Include admin and moderator in reporting email
2021-11-18 15:08:00 -08:00
21c90ac99e
Use groups not permissions
2021-11-18 14:51:00 -08:00
3787a31c67
Updates image helpers on site
2021-11-18 14:39:22 -08:00
41dd915d7f
Email templates
2021-11-17 20:22:00 -08:00
9961a08c93
Adds Galician locale
2021-11-17 10:02:39 -08:00
e3fec5885a
Fixes logic on nodeinfo page
2021-11-16 16:20:29 -08:00
6dd7eebd98
Fixes tests
2021-11-16 10:16:28 -08:00
50ca16a46f
Merge branch 'main' into inventaire-connector-tests
2021-11-16 09:59:50 -08:00
8658e36ca8
code formatting
2021-11-16 20:40:22 +11:00
03c59f2431
improve security on isni url
2021-11-16 20:37:37 +11:00
9ca18d9cd4
isni utils cleanup
...
Utilises the requests module's built in functionality to pass params as a dict
which is url encoded by requests.
2021-11-16 20:35:47 +11:00
ec39346e67
check shelf.editable instead of custom filter
2021-11-16 19:26:49 +11:00
2968145627
Merge pull request #1614 from bookwyrm-social/outbox-error
...
Safer call to get preview image or books
2021-11-15 13:47:00 -08:00
f22ae23574
Safer call to get preview image or books
2021-11-15 13:34:02 -08:00
58f63280fd
Merge pull request #1612 from bookwyrm-social/lithuanian-space
...
Preserve spaces between links
2021-11-15 12:11:36 -08:00
5e5cb26290
Preserve spaces between links
2021-11-15 11:47:39 -08:00
bcfe13bb4e
Sort followers/following lists by if you follow the user
2021-11-15 11:28:43 -08:00
7d66013b52
Adds Lithuanian to the user options
2021-11-15 10:26:00 -08:00
afbc742f47
Merge pull request #1600 from bookwyrm-social/import-field-names
...
Refactors import process
2021-11-15 09:59:54 -08:00
30afe42b3a
Removes extra space in progress bar
2021-11-15 09:41:05 -08:00
83e468a4f8
Fixes "indeterminate" state of progress indicator on screen reader
2021-11-15 09:34:36 -08:00
77ee1147d5
Adds return_first tests to book_search
2021-11-15 09:03:00 -08:00
eab2ec0ffd
code cleanup in is_shelf_type template tag
2021-11-15 21:19:16 +11:00
168a2488e2
refactor shelf activity on book page
...
- disallow moving from custom shelf to a reading status shelf with shelf_selector
- always use shelve_button for moving books from a reading status shelf
- redesign shelf information as a list of boxes
2021-11-15 20:59:22 +11:00
8612cf654d
Invalid href
2021-11-14 11:31:47 -08:00
14e2960d06
Update legacy jobs
2021-11-14 10:58:46 -08:00
9f6796bbf5
Safer request for normalized data
2021-11-14 10:29:12 -08:00
31f3351854
Fixes bug comparing dates to nonetype
2021-11-14 10:22:26 -08:00
8cede05d32
Retry hanging items
2021-11-14 10:20:14 -08:00
f92863ad3e
Notify when import completes
2021-11-14 09:56:23 -08:00
47b98ad0d9
Track completed items on job
2021-11-14 09:04:12 -08:00
9e673834dc
Check for duplicates
2021-11-14 08:35:16 -08:00
6cca3f9772
Updates test data
2021-11-14 07:57:13 -08:00
2748e0a824
Check for existing reviews/ratings on import items
2021-11-14 07:50:19 -08:00
bdc3f6828b
Python formatting
2021-11-14 07:11:48 -08:00
c614f638fd
Merge branch 'import-field-names' of github.com:bookwyrm-social/bookwyrm into import-field-names
2021-11-14 07:06:48 -08:00
3357953a53
whoops forgot inventaire_id
2021-11-14 21:26:23 +11:00
8495cf8a45
don't delete non-form data when editing authors
...
fixes #1584
This is a temporary fix. As Mouse has suggested, ultimately it would be good to re-import data from one or more of the linked data sources if there is anything missing.
2021-11-14 21:21:37 +11:00
32d0d8d027
Expand librarything csv processing tests
2021-11-13 13:04:54 -08:00
7f06ee3844
Fixes getting isbn for librarything imports
2021-11-13 12:46:27 -08:00
fb91c33682
Fixes isbn assignment for goodreads
2021-11-13 12:24:16 -08:00
a9622942cd
Test correctly adding goodreads isbns
2021-11-13 12:11:07 -08:00
8b7720c8b8
Use "reject" instead of "delete" on review page
2021-11-13 11:54:28 -08:00
712d8ecfb4
Don't show empty stars when there's no review
2021-11-13 11:52:08 -08:00
1e46de4c9d
Associate imported review with import item
2021-11-13 11:44:05 -08:00
1e2dca402b
Adds null value to breadcrumb links
2021-11-13 11:40:19 -08:00
644d969330
Fixes importer tests
2021-11-13 11:22:07 -08:00
4dae851da0
Adds breadcrumbs
2021-11-13 11:18:10 -08:00
e77eea9c81
Adds tests for import manual review
2021-11-13 10:52:11 -08:00
c3156a1de5
Fixes import path in test
2021-11-13 10:22:28 -08:00
628f104b13
Separates out imports views tests
2021-11-13 10:16:25 -08:00
232e051dcb
Fixes import job creates in tests
2021-11-13 10:16:05 -08:00
3bdda973bc
Creates subdirectory for import views tests
2021-11-13 09:52:09 -08:00
d3f23b4a0a
Updates calls in tests
2021-11-13 09:50:56 -08:00
659d0f19eb
Improves import table ui
...
adds table container, plays with display a bit
2021-11-13 09:43:52 -08:00
60fb1ac2e6
More flexible templates
2021-11-13 09:34:10 -08:00
acc32d579e
Preview review in import preview
2021-11-13 09:22:35 -08:00
c245ad09bb
Make sure book is in the right format
2021-11-13 09:07:50 -08:00
08f4ad6cd4
Fixes call to import task
2021-11-13 09:02:42 -08:00
40fff02eec
Approve or delete import guesses
2021-11-12 17:10:47 -08:00
221cde9be4
Adds manual review view
2021-11-12 16:24:45 -08:00
9bff27e61f
Separate import classes into files
2021-11-12 15:50:33 -08:00
be26e8363a
Create import directory
2021-11-12 15:43:15 -08:00
5558ed810e
Show manual review flag
2021-11-12 15:40:07 -08:00
6a5a598345
Raise errors when import items fail
...
This should make is way easier to debug
2021-11-12 15:17:01 -08:00
b784dcdb46
Removes uninformative test
2021-11-12 15:07:26 -08:00
1d0f6d5243
Python formatting
2021-11-12 15:06:23 -08:00
6161f60695
Use normalized data in table
2021-11-12 14:54:20 -08:00
61eaf51310
Fixes html validity
2021-11-12 14:49:24 -08:00
e09c02017c
Fixes title/author search handling
2021-11-12 14:46:39 -08:00
60c777ed49
Updates tests
2021-11-12 14:41:25 -08:00
d8197cdcfa
Indicate retry on status page
2021-11-12 14:38:41 -08:00
a65f07e0bf
Adds retry page
2021-11-12 14:36:28 -08:00
2a84c0a370
title author search already working correctly with return first
2021-11-12 13:59:54 -08:00
80c1954aa3
Fixes first_search_result behavior
2021-11-12 13:48:31 -08:00
1e8269b6c9
Refactors import status view
2021-11-12 13:10:52 -08:00
309d289a65
A few more mocks
2021-11-12 10:49:49 -08:00
cad5a128ac
Fixes call to add_status signal
2021-11-12 10:19:13 -08:00
e6a251fdad
Updates mocks across tests
2021-11-12 10:07:38 -08:00
f71ef286b6
Updates mocks
2021-11-12 08:55:47 -08:00
3190ef4346
Deprioritize adding old statuses to timelines
2021-11-11 19:19:23 -08:00
9fee860b00
Adds enum for queue names
2021-11-11 19:10:22 -08:00
6aa57d4d34
Set queue for broadcast task
2021-11-11 19:00:01 -08:00
c33d791974
adds tests for new task system
2021-11-11 15:17:32 -08:00
908c9dc689
Use many small tasks instead of one big task
2021-11-11 14:42:29 -08:00
f0ce236ffc
Removes unused code
2021-11-11 14:28:49 -08:00
be94818a10
Fixes views tests
2021-11-11 14:27:29 -08:00
915c41f59f
Merge branch 'main' into import-field-names
2021-11-11 14:08:16 -08:00
50ab4e8248
Updates model tests
2021-11-11 14:08:00 -08:00
c37472b484
Merge pull request #1599 from bookwyrm-social/remove-serialize-image-helper
...
Remove serialize image helper
2021-11-11 13:53:17 -08:00
ffcaef0559
Python formatting
2021-11-11 13:39:58 -08:00
8c4e8361f2
Fixes tests
2021-11-11 13:35:56 -08:00
c744faf393
Fixes dictionary list html validity
2021-11-11 13:00:34 -08:00
d807774c2d
Fixes label for privacy field
2021-11-11 12:53:48 -08:00
efcf7824dd
iUpdates storygraph tests
2021-11-11 12:39:12 -08:00
5967834805
Adds migration
2021-11-11 12:29:51 -08:00
f3bcced0a0
Adds shelf mappings
2021-11-11 12:29:38 -08:00
147dd95e8d
Removes unused import
2021-11-11 11:59:15 -08:00
a95e031140
Validate html in unit tests
2021-11-11 11:33:12 -08:00
4d574a3536
Process dates in librarything import
2021-11-11 09:54:36 -08:00
20baf9385d
Updates goodreads tests
2021-11-11 09:22:44 -08:00
4ccd9fc633
Use generalized mappings to handle import
2021-11-10 16:49:54 -08:00
81450ac2d5
Merge pull request #1597 from bookwyrm-social/import-fixes
...
Don't broadcast imported reviews outside bookwyrm
2021-11-10 12:32:51 -08:00
0736c7e160
Uses general names for fields in parsed csvs
2021-11-10 11:10:09 -08:00
717da918cf
Use social media preview images
2021-11-10 10:59:21 -08:00
d61595abb9
Clearer syntax
2021-11-10 10:50:05 -08:00
cf477a03ae
Corrects broadcast flow for objects
2021-11-10 10:39:51 -08:00
7e784fa705
Removes used import
2021-11-10 10:35:37 -08:00
9815e9e100
Python formatting
2021-11-10 10:30:18 -08:00
4f5d23e785
Replace image_serialzier helper with built-in serializers
2021-11-10 10:28:43 -08:00
d204e8dbb8
Merge pull request #1247 from joachimesque/image-absolute-url-getter
...
Add get_absolute_url to ImageField
2021-11-10 10:27:29 -08:00
97a71f5e39
Cleans up software check syntax
2021-11-10 09:55:56 -08:00
1b9d08414f
Adds storygraph tests
2021-11-10 09:55:52 -08:00
aeef472ee1
Fixes flow in checking software for broadcast
2021-11-10 09:33:00 -08:00
20c6a3ea1c
Creates generic importer test file
...
And removes some tests that duplicate the generic tests
2021-11-10 09:32:53 -08:00
eb62474b97
fix broken book links in Discover
2021-11-10 22:04:19 +11:00
3f6b0608b2
Show user and book names for reading actions in Discover
...
fixes #1596
This uses the same technique as #1572 to ensure read statuses from GeneratedNotes are translated.
2021-11-10 21:37:16 +11:00
e19c4620ce
Don't broadcast imported reviews outside bookwyrm
2021-11-08 12:00:08 -08:00
dfe92a27c0
use shelf name if not default shelf
...
(instead of shelf.identifier)
2021-11-06 11:10:58 +11:00
d8098357e6
match page title to active shelf
...
resolves #1586
2021-11-06 10:53:41 +11:00
c3ba7ba547
pylint Y U like this?
2021-11-01 20:04:25 +11:00
6556090524
Update existing authors when isni data available
...
When an existing author is selected as a new author when editing a book,
if they have an ISNI ID recorded we check the record and augment the local
database record from the ISNI data.
Also dedupes author aliases for this feature and when adding a completely
new author.
2021-11-01 19:50:49 +11:00
c845b7a5d0
code cleanup
2021-11-01 16:00:34 +11:00
775470a852
normalise isnis
...
Some isnis are imported with spaces and some not.
This normalises them for comparison and creating URLs
2021-11-01 15:48:52 +11:00
55ac80cc16
ugh pylint
2021-11-01 12:01:57 +11:00
1533b55a32
lint code
2021-11-01 11:58:08 +11:00
b593b9c9d3
Display link to isni record on author page
2021-11-01 11:45:47 +11:00
630f508ee4
code cleanup
2021-11-01 11:39:37 +11:00
552980e208
select correct isni record when adding authors
...
The original implementation of this was so, so broken.
Now it's not.
2021-11-01 11:34:32 +11:00
37148c5127
display isni bio with existing author name
...
If an existing author has an isni on record and it matches an author from the isni api call,
display the isni short description to aid with identifying the appropriate author.
2021-11-01 10:26:17 +11:00
30a959dfce
make pylint happy
2021-11-01 10:20:19 +11:00
3cfd31f1fe
hide isni authors if isni in local db
...
Check the authors suggested from the local DB for a matching ISNI when pulling authors from ISNI.
i.e. we do not want to suggest the same author twice when we *know* it is the same author.
2021-10-31 20:48:47 +11:00
bce5f3f3b5
populate new authors with isni data
...
If a user selects an author pulled from the ISNI service when editing a book, use any relevant data from ISNI to populate the new author record.
This includes
- bio
- aliases
- isni
- wikipedia url
- viaf
2021-10-31 17:58:15 +11:00
45158a1c03
improve isni search logic
...
- skip ISNIs that aren't persons
- don't look for text values in non-existent nameTitle elements
2021-10-30 09:24:42 +11:00
87ed6f8380
code formatting
2021-10-29 21:14:32 +11:00
d87e1b1567
fix encoding
...
The OCLC server claims that the xml payload is encoded as latin1 (ISO-8859-1).
This causes Requests to incorrectly encode things as latin1, when actually everything is (thank goodness) UTF-8.
We can fix it by just telling Requests that it is really UTF-8
With thanks to Tex Texin, creator of http://i18nqa.com/debug/utf8-debug.html
2021-10-29 21:00:35 +11:00
f2e4865adf
check isni sources when editing book authors
2021-10-29 16:13:05 +11:00
625cfac76f
isni author lookup utility
2021-10-29 16:12:31 +11:00
d3e4c7e8d9
Removes change to boolean logic
2021-10-27 10:40:37 -07:00
07446fa7d2
Adds more tests for the inventaire connector
2021-10-27 10:03:09 -07:00
56fd147c88
Update test_status_model.py
2021-10-27 19:00:09 +02:00
b956b79bd0
Add full URL generation to image_serializer
2021-10-27 18:56:37 +02:00
35bd4a4071
Apply review suggestion
2021-10-27 18:13:47 +02:00
8ba875af4a
Improve federation compability with Hubzilla and Zap
...
Co-authored-by: hubzilla <redmatrix@users.noreply.github.com>
Fixes #1564
2021-10-26 14:41:06 -07:00
6ba605cbd0
Merge pull request #1577 from hughrun/sort-recent
...
sort shelves by latest shelved date
2021-10-26 14:31:57 -07:00
0e023fd9c9
Merge pull request #1572 from hughrun/trans-updates
...
translate all read statuses
2021-10-26 14:28:49 -07:00
f4573996e6
black wants double quotes
2021-10-26 21:01:45 +11:00
097da148be
sort shelves by latest shelved date
...
Display the latest 2 books to be shelved in each shelf, when in the homepage feed view.
fixes #1576
2021-10-26 20:17:53 +11:00
24bf3f408c
Fixes duplicate books in author page when there are mulitple authors
2021-10-25 11:06:54 -07:00
c5d530c0c4
translate all read statuses
...
This fixes #1566 - "Already translated strings sometimes show up untranslated in UI"
- add generatednote status header template
- include the relevant template (to-read/reading/read) based on the status.content
- remove GeneratedNote block from note status header template
This is probably not the most correct way of resolving the problem, but it's simple and it works.
2021-10-25 15:30:48 +11:00
9a07c11b19
Fixes group quotes and button whitespace
2021-10-24 06:43:31 -07:00
d80a28e128
Consistent quotes around group names in notifications
2021-10-23 08:00:45 -07:00
1e6390a405
Fixes whitespace in translation strings
2021-10-23 06:59:06 -07:00
ac749d94b2
Merge pull request #1562 from bookwyrm-social/suggested-users-tests
...
Adds a few more tests to the suggested users module
2021-10-22 10:39:11 -07:00
f39ff96a64
Adds a few more tests to the suggested users module
2021-10-22 10:25:33 -07:00
bdb6e4c911
fix template indenting
...
whoops
2021-10-22 21:15:48 +11:00
1d791d950f
add migration for updated notification types
2021-10-22 20:30:25 +11:00
bcbff4f002
Merge branch 'main' into group-privacy
2021-10-22 20:28:31 +11:00
6bc86f189f
notify group members of group changes
...
Send a notification to all group members when group name, description, or privacy are changed.
2021-10-22 20:23:45 +11:00
c9deda8fdd
remove superfluous field
2021-10-22 20:21:55 +11:00
80edc1e95e
remove trailing spaces
2021-10-22 20:16:48 +11:00
bd20c9ce2c
remove followers group visibility test
...
Also updates description of group.followers_filter() override
2021-10-22 18:42:18 +11:00
19c7e43f50
remove followers privacy option from group form
2021-10-22 18:40:55 +11:00
278a9de673
Removes duplicate assertions in author view test
2021-10-20 18:29:00 -07:00
72dc21e82a
Adds tests and fixes unset ordering warnings
2021-10-20 18:27:19 -07:00
d706b26ac9
Python formatting
2021-10-20 18:11:31 -07:00
14682ed8c6
Prefect related data in author view
2021-10-20 18:04:29 -07:00
de93beca84
Adds shelve buttons to books on author page
2021-10-20 17:51:42 -07:00
3eb3225d2c
Adds pagination to the template
2021-10-20 17:42:19 -07:00
Hugh Rundle
Joachim
Chad Nelson
Mouse Reeve