efficiency improvement to remove_from_group

This commit is contained in:
Hugh Rundle 2021-10-16 08:17:42 +11:00
parent 2f38af4faa
commit 97ea61dd7e
1 changed files with 1 additions and 5 deletions

View File

@ -101,11 +101,7 @@ class List(OrderedCollectionMixin, BookWyrmModel):
def remove_from_group(cls, owner, user): def remove_from_group(cls, owner, user):
"""remove a list from a group""" """remove a list from a group"""
memberships = GroupMember.objects.filter(group__user=owner, user=user).all() cls.objects.filter(group__user=owner, user=user).all().update(
for membership in memberships:
# remove this user's group-curated lists from the group
cls.objects.filter(group=membership.group, user=membership.user).update(
group=None, curation="closed" group=None, curation="closed"
) )